Skip to content

[Code] improve file tree#27653

Merged
WangQianliang merged 3 commits intoelastic:feature/merge-codefrom
WangQianliang:code-improve-file-tree
Dec 27, 2018
Merged

[Code] improve file tree#27653
WangQianliang merged 3 commits intoelastic:feature/merge-codefrom
WangQianliang:code-improve-file-tree

Conversation

@WangQianliang
Copy link
Contributor

Summary

  • implement design styles
  • do not request parent node after first request file tree
  • do not send request when node is already exist

screen shot 2018-12-18 at 3 08 37 pm

@WangQianliang WangQianliang requested a review from a team as a code owner December 21, 2018 07:32
@WangQianliang WangQianliang changed the base branch from master to feature/merge-code December 21, 2018 07:32
@WangQianliang WangQianliang mentioned this pull request Dec 21, 2018
3 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the warning message be the same as success ?

Copy link
Contributor

@spacedragon spacedragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mw-ding
Copy link
Contributor

mw-ding commented Dec 26, 2018

@WangQianliang can you rebase so that the clone worker unit test won't fail. Also, it looks like the snapshot test failed as well. Let's try to check in this change ASAP.

@elasticmachine
Copy link
Contributor

💔 Build Failed

implement design styles;optimize api call
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@WangQianliang WangQianliang merged commit fd81197 into elastic:feature/merge-code Dec 27, 2018
@WangQianliang WangQianliang deleted the code-improve-file-tree branch December 27, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants