Combine node and cluster warnings in Upgrade Assistant#27508
Merged
joshdover merged 1 commit intoelastic:masterfrom Dec 19, 2018
Merged
Combine node and cluster warnings in Upgrade Assistant#27508joshdover merged 1 commit intoelastic:masterfrom
joshdover merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations |
Contributor
💚 Build Succeeded |
tylersmalley
approved these changes
Dec 19, 2018
Member
|
This LGTM Unrelated, the documentation page returned for the thread_pool size 404's cc: @gwbrown This is running ES 6.6: |
|
@tylersmalley Thank you! I've opened elastic/elasticsearch#36854 to fix the doc links - there were others that were wrong as well. |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Dec 19, 2018
joshdover
added a commit
that referenced
this pull request
Dec 19, 2018
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Jan 3, 2019
joshdover
added a commit
that referenced
this pull request
Jan 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need to show all the node-level deprecations in the cluster tab. In 7.0, this Elasticsearch API may remove the node_settings completely and do this combination for us. At that time, we should remove the usage of the node_settings key.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This includes a feature addition or change that requires a release note and was labeled appropriately