Skip to content

Combine node and cluster warnings in Upgrade Assistant#27508

Merged
joshdover merged 1 commit intoelastic:masterfrom
joshdover:ua-node-to-cluster
Dec 19, 2018
Merged

Combine node and cluster warnings in Upgrade Assistant#27508
joshdover merged 1 commit intoelastic:masterfrom
joshdover:ua-node-to-cluster

Conversation

@joshdover
Copy link
Contributor

Summary

We need to show all the node-level deprecations in the cluster tab. In 7.0, this Elasticsearch API may remove the node_settings completely and do this combination for us. At that time, we should remove the usage of the node_settings key.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tylersmalley
Copy link
Member

tylersmalley commented Dec 19, 2018

This LGTM

Unrelated, the documentation page returned for the thread_pool size 404's cc: @gwbrown

This is running ES 6.6:

{
  "cluster_settings" : [ ],
  "node_settings" : [
    {
      "level" : "critical",
      "message" : "Index thread pool removed in favor of combined write thread pool",
      "url" : "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking_70_cluster_changes.html#_index_thread_pool",
      "details" : "nodes with index thread pool settings: [xqd9QOH]"
    }
  ],
  "index_settings" : { }
}

@gwbrown
Copy link

gwbrown commented Dec 19, 2018

@tylersmalley Thank you! I've opened elastic/elasticsearch#36854 to fix the doc links - there were others that were wrong as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport pending bug Fixes for quality problems that affect the customer experience Team:Operations Kibana-Operations Team v6.6.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments