[Monitoring] Fixing issue with EUI table filtering in monitoring UI#27504
Conversation
|
Pinging @elastic/stack-monitoring |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
chrisronline
force-pushed
the
monitoring/eui_filtering_tables
branch
from
cb7b230 to
087afc6
Compare
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
I addressed the core issue requiring the mentioned PR through this commit: 173c79b. More details in the issue |
💔 Build Failed |
💚 Build Succeeded |
|
@justinkambic @mattapperson This is now ready for review again! |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
|
retest |
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
I tested this locally and it seemed to work fine.
Code LGTM, added some comments.
| @@ -18,7 +18,7 @@ class ListingUI extends PureComponent { | |||
| return [ | |||
| { | |||
| name: 'Name', | |||
There was a problem hiding this comment.
Tangential to this PR, but should these column names be translated?
There was a problem hiding this comment.
Yes, great catch
| search.box['data-test-subj'] = 'monitoringTableToolBar'; | ||
| } | ||
|
|
||
| if (search.box && !search.box.schema) { |
There was a problem hiding this comment.
I didn't find any issues related to this but I'm curious about what it's accomplishing. It doesn't conform to the proptypes specified in the docs, so for my own purposes I'm wondering what it does.
There was a problem hiding this comment.
Ah, so I'm just allowing any future monitoring tables to specify a schema manually, but if they didn't, set the schema property to true so the EUI code does it automatically.
💔 Build Failed |
|
retest |
💚 Build Succeeded |
💚 Build Succeeded |
…lastic#27504) * Ensure the schema is set * Flatten certain table data lists to ensure the default field filtering works * Fix issue with tests * Fix issue with sort key name * Readd localization that was removed
|
Backport: 6.x: 9c842ee |
3 participants
This is a follow up PR for #27064 that addresses issues with filtering tables in the new EUI monitoring tables. We basically need to ensure a schema is set for each table for the filtering to work.
To test, please load any/all monitoring UI tables and try and filter using the search bar and ensure the results are as expected.