[Reporting] Re-enable some skipped tests#27094
Merged
tsullivan merged 8 commits intoelastic:masterfrom Dec 14, 2018
Merged
Conversation
tsullivan
added
review
test
v7.0.0
zDeprecated Feature:Reporting
tsullivan
changed the title
tsullivan
commented
Dec 12, 2018
| * Unfortunately we don't have a logger in scope to log a warning. | ||
| */ | ||
| err; // no-op | ||
| }); |
Member
Author
There was a problem hiding this comment.
Normally, we would want to log a warning here, but there is no logger in context in this function.
We could also check the statusCode on the err object to try to be certain it's a case of attempt to create an index that already exists. It isn't super specific though, the statusCode will just be 400.
Member
Author
There was a problem hiding this comment.
Note: The FIXME was that we should log a warning here. That'll take a bit of refactoring to get a logger in scope
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
| @@ -13,11 +13,10 @@ export default function ({ getService }) { | |||
| const usageAPI = getService('usageAPI'); | |||
|
|
|||
| describe('reporting usage', () => { | |||
joelgriffith
approved these changes
Dec 13, 2018
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Dec 14, 2018
* [Test/Reporting] Enable "generates a report with/without data" * navigate to discover before each csv test * get another test working * re-enable more tests * refactor api usage tests * catch error in createIndex to avoid race condition in test * delete reports before
Member
Author
|
6.x/6.6: #27177 |
tsullivan
added a commit
that referenced
this pull request
Dec 14, 2018
* [Test/Reporting] Enable "generates a report with/without data" * navigate to discover before each csv test * get another test working * re-enable more tests * refactor api usage tests * catch error in createIndex to avoid race condition in test * delete reports before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable Reporting tests that were skipped in #26877
Root cause of why the tests were failing is addressed in #26995
This also includes quite a few changes to tests to make them able to run standalone.