Merged
Conversation
Contributor
💚 Build Succeeded |
w33ble
suggested changes
Dec 12, 2018
Contributor
w33ble
left a comment
w33ble
left a comment
There was a problem hiding this comment.
The description says it's using https://www.elastic.co/guide/en/kibana/current/canvas-tinymath-functions.html, which seems correct.
However, the code is actually linking to https://www.elastic.co/guide/en/kibana/current/canvas.html
cqliu1
force-pushed
the
fix/tinymath-links
branch
from
696df7f to
b1742c5
Compare
Contributor
Author
|
Oops, I pasted the wrong link. Using the correct links now. |
Contributor
💚 Build Succeeded |
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Dec 12, 2018
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Dec 12, 2018
cqliu1
added a commit
that referenced
this pull request
Dec 13, 2018
cqliu1
added a commit
that referenced
this pull request
Dec 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26451.
This updates the TinyMath reference links to https://www.elastic.co/guide/en/kibana/current/canvas-tinymath-functions.html.