Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: elasticsearch-js next #27051

Closed
wants to merge 80 commits into from
Closed

WIP: elasticsearch-js next #27051

wants to merge 80 commits into from

Conversation

delvedor
Copy link
Member

As titled 🚀

@delvedor delvedor added the WIP Work in progress label Dec 12, 2018
@elastic elastic deleted a comment from elasticmachine Dec 13, 2018
@elastic elastic deleted a comment from elasticmachine Dec 13, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@delvedor delvedor requested a review from a team as a code owner December 18, 2018 12:22
@elasticmachine
Copy link
Contributor

💔 Build Failed

delvedor
delvedor commented Dec 18, 2018
View reviewed changes
src/server/saved_objects/service/lib/decorate_es_error.js
// TODO: The new client considers as "service unavailable"
// (so worth of request retry) errors with status codes 502, 503, and 504.
// Do we want to handle them as well?
error.statusCode === 503 // Service Unavailable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: The new client considers as "service unavailable" (so worth of request retry) errors with status codes 502, 503, and 504, we need to handle them as well.

@delvedor delvedor mentioned this pull request Dec 18, 2018
Closed
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@delvedor
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@delvedor delvedor requested a review from a team as a code owner February 11, 2019 14:11
@elasticmachine
Copy link
Contributor

💔 Build Failed

@delvedor delvedor mentioned this pull request Apr 24, 2019
Closed
14 tasks
@monfera
Copy link
Contributor

monfera commented Sep 10, 2019

Hi @delvedor what's the plan for this PR?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@delvedor
Copy link
Member Author

@monfera we can close this, as the new client will be added via the new platform.

@azasypkin azasypkin mentioned this pull request Dec 18, 2019
Merged
@jbudz jbudz closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv left review comments

Assignees
No one assigned
Labels
WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@delvedor @elasticmachine @monfera @sorenlouv @jbudz @timroes