adding informational callout when step_info message is present#27046
Merged
bmcconaghy merged 3 commits intoelastic:masterfrom Dec 12, 2018
Merged
adding informational callout when step_info message is present#27046bmcconaghy merged 3 commits intoelastic:masterfrom
bmcconaghy merged 3 commits intoelastic:masterfrom
Conversation
bmcconaghy
added
v6.6.0
v7.0.0-alpha2
Team:Kibana Management
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
cjcenizal
approved these changes
Dec 12, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Tested locally, code LGTM!
...ex_lifecycle_management/public/extend_index_management/components/index_lifecycle_summary.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Dec 12, 2018
…ic#27046) * adding informational callout when step_info message is present * updating test and snapshot * changing title to action status
bmcconaghy
added a commit
that referenced
this pull request
Dec 12, 2018
… (#27074) * adding informational callout when step_info message is present * updating test and snapshot * changing title to action status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26811
Adding an informational callout when there is a step_info message:
You can verify this locally by creating a policy with rollover with max size 1 document, activating warm phase, setting move to warm phase on rollover to true, and setting replicas for warm phase to 6. Attach this policy to an index with name like "testy-1". You'll also want to add this setting to make things happen faster: