[BeatsCM] fix incorrect beat name in enroll command, remove translation of command#27036
Merged
mattapperson merged 1 commit intoelastic:masterfrom Dec 13, 2018
Merged
Conversation
Contributor
💚 Build Succeeded |
justinkambic
approved these changes
Dec 13, 2018
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
Tested the bug on master and then on PR branch - LGTM!
mattapperson
added a commit
to mattapperson/kibana
that referenced
this pull request
Dec 14, 2018
mattapperson
added a commit
that referenced
this pull request
Dec 14, 2018
* [BeatsCM] Fix check for expiry_date_in_millis to allow for non-expiry (#27198) * Fix check for expiry_date_in_millis to allow for non-expiry * fix typo * [BeatsCM] fix incorrect beat name in enroll command, remove translation of command (#27036) * [Beats CM] Add basic license type (#26935) * wrap non error in a try/catch (#26898) * Log token errors to the server (#27170)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of the command only updated for beats enrollment if the OS type selector is changed.
To test, go to enroll a beat, change the OS selector, then change the beat type. If the beat type update in the command, then success 😊