Skip to content

[I18n] Fix wrong FormattedMessage example in readme#27035

Merged
LeanidShutau merged 1 commit intoelastic:masterfrom
LeanidShutau:feature/i18n-update-wrong-readme-example
Dec 13, 2018
Merged

[I18n] Fix wrong FormattedMessage example in readme#27035
LeanidShutau merged 1 commit intoelastic:masterfrom
LeanidShutau:feature/i18n-update-wrong-readme-example

Conversation

@LeanidShutau
Copy link
Contributor

@LeanidShutau LeanidShutau commented Dec 12, 2018

We shouldn't use JSX expression containers for defaultMessage value in <FormattedMessage/>.

// bad
<FormattedMessage
  id="namespace.id"
  defaultMessage={`Default
                   message`}
/>

// good
<FormattedMessage
  id="namespace.id"
  defaultMessage="Default
                  message"
/>

// good
<FormattedMessage
  id="namespace.id"
  defaultMessage='Message with "double" quotes'
/>

@LeanidShutau LeanidShutau added review Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Project:i18n v6.6.0 labels Dec 12, 2018
@LeanidShutau LeanidShutau self-assigned this Dec 12, 2018
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2018

Pinging @elastic/kibana-platform

@LeanidShutau LeanidShutau force-pushed the feature/i18n-update-wrong-readme-example branch from 74740d2 to 66dfd14 Compare December 12, 2018 14:33
azasypkin
azasypkin approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maryia-lapata
maryia-lapata approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@LeanidShutau LeanidShutau removed the request for review from pavel06081991 December 12, 2018 15:00
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 12, 2018

💚 Build Succeeded

joshdover
joshdover approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@LeanidShutau LeanidShutau merged commit 0b480f0 into elastic:master Dec 13, 2018
@LeanidShutau LeanidShutau deleted the feature/i18n-update-wrong-readme-example branch December 13, 2018 08:19
@LeanidShutau LeanidShutau mentioned this pull request Dec 13, 2018
Merged
LeanidShutau added a commit to LeanidShutau/kibana that referenced this pull request Dec 13, 2018
@LeanidShutau
[I18n] Fix wrong FormattedMessage example in readme (elastic#27035)
5e8c41e
LeanidShutau added a commit that referenced this pull request Dec 13, 2018
@LeanidShutau
[I18n] Fix wrong FormattedMessage example in readme (#27035) (#27113)
bb50f4e
@LeanidShutau
Copy link
Contributor Author

LeanidShutau commented Dec 13, 2018

6.x/6.6: bb50f4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azasypkin azasypkin azasypkin approved these changes

+2 more reviewers

@joshdover joshdover joshdover approved these changes

@maryia-lapata maryia-lapata maryia-lapata approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LeanidShutau LeanidShutau

Labels

backported Project:i18n Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v6.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LeanidShutau @elasticmachine @azasypkin @joshdover @maryia-lapata