adding reload indices button to index management#27033
Merged
bmcconaghy merged 2 commits intoelastic:masterfrom Dec 12, 2018
Merged
adding reload indices button to index management#27033bmcconaghy merged 2 commits intoelastic:masterfrom
bmcconaghy merged 2 commits intoelastic:masterfrom
Conversation
bmcconaghy
added
v7.0.0
v6.6.0
Team:Kibana Management
Contributor
💚 Build Succeeded |
cjcenizal
suggested changes
Dec 12, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Tested locally. LGTM overall, just had a few comments/questions.
Also, if the refresh request is in flight for a long time, it might be nice to show the user some feedback by swapping out the "reload" icon with a spinner in the "Reload" button. Note that this adds a slight bit of complexity because I think we'd only want to show it if the user has clicked the button, and not when one of the interval-based reloads is taking place.
Slightly unrelated, but I think we also need to show a spinner for the initial load (but not for reloads). In the current UX, the table just says there are indices while it's loading:
...ck/plugins/index_management/public/sections/index_list/components/index_table/index_table.js
Outdated
Show resolved
Hide resolved
...ck/plugins/index_management/public/sections/index_list/components/index_table/index_table.js
Outdated
Show resolved
Hide resolved
...ck/plugins/index_management/public/sections/index_list/components/index_table/index_table.js
Show resolved
Hide resolved
Contributor
Author
|
@cjcenizal I addressed all your feedback. Please take another look when you get a chance. |
Contributor
💚 Build Succeeded |
bmcconaghy
added a commit
to bmcconaghy/kibana
that referenced
this pull request
Dec 12, 2018
* adding reload indices button to index management * addressing PR feedback
bmcconaghy
added a commit
that referenced
this pull request
Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26710
This PR adds a reload indices button to the index table in index management:
This button clears filters and reloads the whole list of indices. This will allow the user to see indices that have been added since the first visit to the index table.
This PR also refactors the index list component to remove the container and moves all behavior to the index list component.