Skip to content

[Entity Store] Change default log cap behavior to drop #270180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romulets merged 2 commits into from
May 20, 2026
Merged

[Entity Store] Change default log cap behavior to drop #270180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b16a6b
[Entity Store] Change default log cap behavior to drop
romulets May 20, 2026
2d0756a
Changes from make api-docs
kibanamachine May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oas_docs/output/kibana.serverless.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76741,7 +76741,7 @@ paths:
minimum: 0
type: integer
maxLogsPerWindowCapBehavior:
default: defer
default: drop
enum:
- defer
- drop
Expand Down
2 changes: 1 addition & 1 deletion oas_docs/output/kibana.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81950,7 +81950,7 @@ paths:
minimum: 0
type: integer
maxLogsPerWindowCapBehavior:
default: defer
default: drop
enum:
- defer
- drop
Expand Down
2 changes: 1 addition & 1 deletion ...ity/plugins/entity_store/server/domain/logs_extraction/ccs_logs_extraction_client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ describe('CcsLogsExtractionClient', () => {
// behavior is exercised by the dedicated tests at the end of this describe block.
maxTimeWindowSize: '999d',
maxLogsPerWindow: 0,
maxLogsPerWindowCapBehavior: 'defer' as const,
maxLogsPerWindowCapBehavior: 'drop' as const,
};

beforeEach(() => {
Expand Down
2 changes: 1 addition & 1 deletion ...ecurity/plugins/entity_store/server/domain/logs_extraction/logs_extraction_client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ describe('LogsExtractionClient', () => {
delay: '1m',
maxTimeWindowSize: '999d',
maxLogsPerWindow: overrides.maxLogsPerWindow,
maxLogsPerWindowCapBehavior: overrides.maxLogsPerWindowCapBehavior ?? 'defer',
maxLogsPerWindowCapBehavior: overrides.maxLogsPerWindowCapBehavior ?? 'drop',
}),
} as EntityStoreGlobalState;
mockGlobalStateClient.find.mockResolvedValue(globalState);
Expand Down
2 changes: 1 addition & 1 deletion ...tions/security/plugins/entity_store/server/domain/saved_objects/global_state/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const LOG_EXTRACTION_TIMEOUT_DEFAULT = '59s';
export const LOG_EXTRACTION_MAX_TIME_WINDOW_SIZE_DEFAULT = '15m';
// Max total raw log documents to process per task run; 0 = no cap
export const LOG_EXTRACTION_MAX_LOGS_PER_WINDOW_DEFAULT = 500_000;
export const LOG_EXTRACTION_CAP_BEHAVIOR_DEFAULT = 'defer' as const;
export const LOG_EXTRACTION_CAP_BEHAVIOR_DEFAULT = 'drop' as const;

export type LogExtractionConfig = z.infer<typeof LogExtractionConfig>;
export const LogExtractionConfig = z.object({
Expand Down
Loading