Redirecting to /, instead of /login, on the logged out page#26999
Merged
kobelb merged 1 commit intoelastic:masterfrom Dec 12, 2018
Merged
Redirecting to /, instead of /login, on the logged out page#26999kobelb merged 1 commit intoelastic:masterfrom
kobelb merged 1 commit intoelastic:masterfrom
Conversation
We're using the successfully logged out page with the SAML provider currently, so redirecting to the /login page is problematic since they won't be able to login using this url. Instead, we're redirecting them to '/' so that the auth providers can figure out what to do.
kobelb
added
v7.0.0
Team:Security
Contributor
|
Pinging @elastic/kibana-security |
Contributor
💔 Build Failed |
Contributor
Author
|
The last failure was the following:
|
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
legrego
reviewed
Dec 12, 2018
x-pack/plugins/security/public/views/logged_out/components/logged_out_page.tsx
Show resolved
Hide resolved
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Dec 12, 2018
…age (elastic#26999) We're using the successfully logged out page with the SAML provider currently, so redirecting to the /login page is problematic since they won't be able to login using this url. Instead, we're redirecting them to '/' so that the auth providers can figure out what to do.
kobelb
added
the
non-issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using the successfully logged out page with the SAML provider
currently, so redirecting to the
/loginpage is problematic since theywon't be able to login using this url. Instead, we're redirecting them
to
/so that the auth providers can figure out what to do.