[6.5] Fix: Support columns with dots (#26659)#26994
Merged
w33ble merged 2 commits intoelastic:6.5from Dec 12, 2018
Merged
Conversation
Closes elastic#26405 Upgrades tinymath so that columns with dots now work correctly. --- To test, follow the details in elastic#26405. 1. Get some data that has fields with dots in them. Beats data would work, or you can create a test index with just 2 documents as follows: ``` POST test/test { "string":"abc", "with.dot":"abc" } POST test/test { "string":"abcd", "with.dot":"abcd" } ``` 2. Create a pie chart, splitting labels on one of the available fields. Previously, given the POST info above, only `string` would work correctly. Now both (and both of their `.keyword` variants) work correctly. 
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.5: