Skip to content

[CCR] Improve Remote Clusters copy and form validation#26928

Merged
cjcenizal merged 8 commits intoelastic:feature/ccrfrom
cjcenizal:ccr/remote-clusters-copy
Dec 13, 2018
Merged

[CCR] Improve Remote Clusters copy and form validation#26928
cjcenizal merged 8 commits intoelastic:feature/ccrfrom
cjcenizal:ccr/remote-clusters-copy

Conversation

@cjcenizal
Copy link
Contributor

  • Refined Remote Clusters copy
  • Added links to docs
  • Disabled Save button when there are errors
  • Integration seed node validation into form validation

image

@cjcenizal cjcenizal added Feature:CCR and Remote Clusters es-management Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// labels Dec 10, 2018
@cjcenizal cjcenizal requested review from gchaps and sebelga December 10, 2018 22:37
@cjcenizal
Copy link
Contributor Author

@sebelga @yaronp68 @bleskes I also added a "Auto-follow patterns" subtitle to the CCR app. What do you think?

image

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@bleskes
Copy link
Contributor

bleskes commented Dec 11, 2018

@cjcenizal ❤️

@sebelga
Copy link
Contributor

sebelga commented Dec 11, 2018

@cjcenizal Great! Very similar to the first screen I had 😄 What about the empty prompt screen?

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a text translation is missing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The i18n translation is missing ^

@cjcenizal cjcenizal force-pushed the ccr/remote-clusters-copy branch from 6b578ee to 34e0da1 Compare December 11, 2018 23:09
@cjcenizal
Copy link
Contributor Author

cjcenizal commented Dec 11, 2018

Very similar to the first screen I had

Yes, it is. 😄

I tried adding the subtitle to the empty prompt but it seemed a bit cumbersome. I couldn't get the sizing right. I think the message is still clear without it though:

image

@elasticmachine
Copy link
Contributor

💔 Build Failed

@gchaps
Copy link
Contributor

gchaps commented Dec 12, 2018

For the Add remote cluster page

Name
A unique name for the remote cluster.

Seed nodes for cluster discovery
The nodes to query to get the cluster state from the remote cluster. Specify multiple seeds so discovery doesn't fail if a node is unavailable.

Make remote cluster optional
By default, a request fails if any of the specified remote clusters are unavailable. To continue processing requests if this cluster is disconnected, enable Skip if unavailable. Learn more.

Toggle switch: Skip if unavailable

Error message: Fix errors before continuing.

Validation message for Seed nodes
A port is required.
At least one seed node is required.

Hint text underneath Seed nodes field:
An IP address or host name, followed by the port.

Placeholder text in Seed nodes field:
host:port

For the Cross Cluster Replication empty state

Title: Automatically follow remote indices

Text: Use an auto-follow pattern to identify the indices that you want to replicate from a remote cluster.

Button label: Create auto-follow pattern

@cjcenizal
Copy link
Contributor Author

cjcenizal commented Dec 12, 2018

Thanks @gchaps! I made some very slight tweaks to your copy. For the title of the empty state, I had to leave it as-is to maintain parity with the title of this page once an auto-follow pattern has been created.

image

image

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal cjcenizal force-pushed the ccr/remote-clusters-copy branch from da8ad0a to f32ec11 Compare December 13, 2018 02:12
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit b4a492f into elastic:feature/ccr Dec 13, 2018
@cjcenizal cjcenizal deleted the ccr/remote-clusters-copy branch December 13, 2018 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants