Skip to content

[6.x] fixing a11y errors in basic_login_form.tsx and edit_role_page.tsx so we can add a11y rules for tslint (#26902) #26921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhavyarm merged 1 commit into from
Dec 10, 2018
Merged

[6.x] fixing a11y errors in basic_login_form.tsx and edit_role_page.tsx so we can add a11y rules for tslint (#26902) #26921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/security/public/views/login/components/basic_login_form/basic_login_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class BasicLoginFormUI extends Component<Props, State> {
onChange={this.onUsernameChange}
disabled={this.state.isLoading}
isInvalid={false}
aria-required
aria-required={true}
inputRef={this.setUsernameInputRef}
/>
</EuiFormRow>
Expand All @@ -79,7 +79,7 @@ class BasicLoginFormUI extends Component<Props, State> {
onChange={this.onPasswordChange}
disabled={this.state.isLoading}
isInvalid={false}
aria-required
aria-required={true}
/>
</EuiFormRow>

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/security/public/views/management/edit_role/components/edit_role_page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ class EditRolePageUI extends Component<Props, State> {
<Fragment>
<EuiSpacer size="s" />
<EuiText size="s" color="subdued">
<p id="reservedRoleDescription" tabIndex={1}>
<p id="reservedRoleDescription" tabIndex={0}>
<FormattedMessage
id="xpack.security.management.editRole.modifyingReversedRolesDescription"
defaultMessage="Reserved roles are built-in and cannot be removed or modified."
Expand Down