[Alerting v2] Compose Discover follow-up: post-merge review fixes

[jasonrhodes]

Summary

Follow-up to #268774 addressing feedback from Bailey and Yiannis left after merge.

Changes

Bug fix (Yiannis): metadata.tags ?? [] revert — the API schema marks tags as optional but requires .min(1) if present, so sending [] is rejected. The key is now omitted entirely when tags is absent or empty.

Nits (Bailey):

• Merge duplicate @kbn/code-editor imports in compose_discover_child.tsx and query_summary.tsx
• Use paths.ruleCreate constant in rules_list_page.tsx instead of the inline URL string (consistent with the rest of the plugin)
• Replace the inline AstNode interface + unsafe cast in compose_discover_form.tsx with isOptionNode type guard from @elastic/esql

Scout test tracking

The deleted quick_edit_rule.spec.ts tests are tracked in #268958 (child of M2 epic rna-program#482).

🤖 Generated with Claude Code

[yiannisnikolopoulos]

The CI failure is a breaking test in rule_request_mappers.test.ts. The existing test 'strips enabled from metadata (server-managed) but includes description' was asserting tags: [] in the output, written against the old ?? [] behaviour. With the new omit-when-empty spread, tags is absent from the output when the array is empty, so the assertion fails.

Fix:

--- a/x-pack/platform/packages/shared/response-ops/alerting-v2-rule-form/form/utils/rule_request_mappers.test.ts
+++ b/x-pack/platform/packages/shared/response-ops/alerting-v2-rule-form/form/utils/rule_request_mappers.test.ts
@@ -268,9 +268,31 @@ describe('rule_request_mappers', () => {
         name: 'My Rule',
         description: 'A description',
         owner: 'owner',
-        tags: [],
       });
       expect(result.metadata).not.toHaveProperty('enabled');
+      expect(result.metadata).not.toHaveProperty('tags');
+    });
+
+    it('omits tags from metadata when tags array is empty', () => {
+      const formValues: FormValues = {
+        ...baseFormValues,
+        metadata: { ...baseFormValues.metadata, tags: [] },
+      };
+
+      const result = mapFormValuesToRuleRequest(formValues);
+
+      expect(result.metadata).not.toHaveProperty('tags');
+    });
+
+    it('omits tags from metadata when tags is undefined', () => {
+      const formValues: FormValues = {
+        ...baseFormValues,
+        metadata: { ...baseFormValues.metadata, tags: undefined },
+      };
+
+      const result = mapFormValuesToRuleRequest(formValues);
+
+      expect(result.metadata).not.toHaveProperty('tags');
     });

[yiannisnikolopoulos]

Lgtm 👍 , posted a comment for the failing test

[kibanamachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: c308bfe

Failed CI Steps

• FTR Configs #42
• FTR Configs #46
• FTR Configs #202
• Scout Lane #5 - stateful-classic / default
• Scout Lane #6 - stateful-classic / default
• Serverless Investigations - Security Solution Cypress Tests #5

Test Failures

• [job] [logs] Scout Lane #6 - stateful-classic / default / local-stateful-classic - CustomStatusAlert - creates a custom status alert rule
• [job] [logs] Scout Lane #5 - stateful-classic / default / local-stateful-classic - Profiling is setup and data is loaded - Admin user
• [job] [logs] FTR Configs #42 / Serverless Common UI - Management Data View Management creating and deleting default data view index pattern deletion "before all" hook for "should return to index pattern list"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
alertingVTwo	771.0KB	771.0KB	-4.0B

History

• 💔 Build #441731 failed ab057c5
• 💔 Build #441725 failed 87d4381