Skip to content

Adding a11y rules from tslint-microsoft-contrib to tslint #26888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhavyarm merged 8 commits into from
Dec 18, 2018
Merged

Adding a11y rules from tslint-microsoft-contrib to tslint #26888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
96c14a9
removing non-branch commits
bhavyarm Dec 11, 2018
1258230
removing non-branch commits
bhavyarm Dec 11, 2018
aef1805
Merge branch 'a11yTSlint' of github.com:bhavyarm/kibana into a11yTSlint
bhavyarm Dec 13, 2018
fb874b1
removing non-branch commits
bhavyarm Dec 11, 2018
dc0b440
Merge branch 'a11yTSlint' of github.com:bhavyarm/kibana into a11yTSlint
bhavyarm Dec 13, 2018
6975ef4
removing non-branch commits
bhavyarm Dec 11, 2018
d6d050d
Merge branch 'a11yTSlint' of github.com:bhavyarm/kibana into a11yTSlint
bhavyarm Dec 14, 2018
52e6371
Merge branch 'master' into a11yTSlint
bhavyarm Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@
"tslint": "^5.11.0",
"tslint-config-prettier": "^1.15.0",
"tslint-plugin-prettier": "^2.0.0",
"tslint-microsoft-contrib": "^6.0.0",
"typescript": "^3.0.3",
"vinyl-fs": "^3.0.2",
"xml2js": "^0.4.19",
Expand Down
19 changes: 19 additions & 0 deletions tslint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,34 @@ extends:
- tslint:recommended
- tslint-config-prettier


Copy link
Copy Markdown
Contributor

@azasypkin azasypkin Dec 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: likely not necessary change.

rulesDirectory:
- tslint-plugin-prettier
- src/dev/tslint/rules
- node_modules/tslint-microsoft-contrib

rules:
prettier: true
object-literal-sort-keys: false
interface-name: false
no-default-export: true
react-a11y-anchors: true
react-a11y-aria-unsupported-elements: true
react-a11y-event-has-role: true
react-a11y-image-button-has-alt: true
react-a11y-img-has-alt: true
react-a11y-input-elements: true
react-a11y-lang: true
react-a11y-meta: true
react-a11y-no-onchange: true
react-a11y-props: true
react-a11y-proptypes: true
react-a11y-required: true
react-a11y-role-has-required-aria-props: true
react-a11y-role-supports-aria-props: true
react-a11y-role: true
react-a11y-tabindex-no-positive: true
react-a11y-titles: true
require-license-header:
- true
- |-
Expand Down
13 changes: 13 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20377,6 +20377,13 @@ tslint-config-prettier@^1.15.0:
resolved "https://registry.yarnpkg.com/tslint-config-prettier/-/tslint-config-prettier-1.15.0.tgz#76b9714399004ab6831fdcf76d89b73691c812cf"
integrity sha512-06CgrHJxJmNYVgsmeMoa1KXzQRoOdvfkqnJth6XUkNeOz707qxN0WfxfhYwhL5kXHHbYJRby2bqAPKwThlZPhw==

tslint-microsoft-contrib@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/tslint-microsoft-contrib/-/tslint-microsoft-contrib-6.0.0.tgz#7bff73c9ad7a0b7eb5cdb04906de58f42a2bf7a2"
integrity sha512-R//efwn+34IUjTJeYgNDAJdzG0jyLWIehygPt/PHuZAieTolFVS56FgeFW7DOLap9ghXzMiFPTmDgm54qaL7QA==
dependencies:
tsutils "^2.27.2 <2.29.0"

tslint-plugin-prettier@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/tslint-plugin-prettier/-/tslint-plugin-prettier-2.0.0.tgz#ade328b26c71f37418d4d01187dca232a7447b49"
Expand Down Expand Up @@ -20410,6 +20417,12 @@ tsutils@^2.27.2:
dependencies:
tslib "^1.8.1"

"tsutils@^2.27.2 <2.29.0":
version "2.28.0"
resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-2.28.0.tgz#6bd71e160828f9d019b6f4e844742228f85169a1"
dependencies:
tslib "^1.8.1"

tty-browserify@0.0.0:
version "0.0.0"
resolved "https://registry.yarnpkg.com/tty-browserify/-/tty-browserify-0.0.0.tgz#a157ba402da24e9bf957f9aa69d524eed42901a6"
Expand Down