[KQL] Bring back config deprecations#268872
Merged
Merged
Conversation
afharo
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
afharo
added
Duty:Core
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
…o/kibana into kql/bring-back-config-deprecations
stratoula
approved these changes
May 12, 2026
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
LGTM, tested locally.
Yeah def a misunderstanding because it was deleted here e23c55a#diff-0a87013bdf7a65805f246c8f3d9e04340c9432afa521ae52e0d96d3c82239c4b
Thanks for fixing it Alejandro
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @afharo |
Contributor
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/25743784179 |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 12, 2026
# Backport This will backport the following commits from `main` to `9.4`: - [[KQL] Bring back config deprecations (#268872)](#268872) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2026-05-12T15:15:04Z","message":"[KQL] Bring back config deprecations (#268872)\n\n## Summary\n\nIt looks like [this\nconversation](https://github.com/elastic/kibana/pull/246674#discussion_r2668848366)\nhad a misunderstanding: it focused on the `unifiedSearch` -> `kql`\nchange, but it forgot the pre-existing rename from `data.autocomplete`\nto `unifiedSearch.autocomplete`.\n\nWe've seen some customers hitting this old path, so this PR brings it\nback.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"8713573409f0be7c5baf98e566224becb621ac48","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Presentation","release_note:skip","backport:version","Duty:Core","v9.5.0","v9.4.1"],"title":"[KQL] Bring back config deprecations","number":268872,"url":"https://github.com/elastic/kibana/pull/268872","mergeCommit":{"message":"[KQL] Bring back config deprecations (#268872)\n\n## Summary\n\nIt looks like [this\nconversation](https://github.com/elastic/kibana/pull/246674#discussion_r2668848366)\nhad a misunderstanding: it focused on the `unifiedSearch` -> `kql`\nchange, but it forgot the pre-existing rename from `data.autocomplete`\nto `unifiedSearch.autocomplete`.\n\nWe've seen some customers hitting this old path, so this PR brings it\nback.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"8713573409f0be7c5baf98e566224becb621ac48"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/268872","number":268872,"mergeCommit":{"message":"[KQL] Bring back config deprecations (#268872)\n\n## Summary\n\nIt looks like [this\nconversation](https://github.com/elastic/kibana/pull/246674#discussion_r2668848366)\nhad a misunderstanding: it focused on the `unifiedSearch` -> `kql`\nchange, but it forgot the pre-existing rename from `data.autocomplete`\nto `unifiedSearch.autocomplete`.\n\nWe've seen some customers hitting this old path, so this PR brings it\nback.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"8713573409f0be7c5baf98e566224becb621ac48"}},{"branch":"9.4","label":"v9.4.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 13, 2026
## Summary It looks like [this conversation](elastic#246674 (comment)) had a misunderstanding: it focused on the `unifiedSearch` -> `kql` change, but it forgot the pre-existing rename from `data.autocomplete` to `unifiedSearch.autocomplete`. We've seen some customers hitting this old path, so this PR brings it back. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
DennisKo
pushed a commit
to DennisKo/kibana
that referenced
this pull request
May 13, 2026
## Summary It looks like [this conversation](elastic#246674 (comment)) had a misunderstanding: it focused on the `unifiedSearch` -> `kql` change, but it forgot the pre-existing rename from `data.autocomplete` to `unifiedSearch.autocomplete`. We've seen some customers hitting this old path, so this PR brings it back. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
florent-leborgne
added a commit
that referenced
this pull request
May 21, 2026
…269868) ## Summary This PR addresses elastic/docs-content#6511. The page [General settings in Kibana](https://www.elastic.co/docs/reference/kibana/configuration-reference/general-settings) lists \`data.autocomplete.valueSuggestions.terminateAfter\` and \`data.autocomplete.valueSuggestions.timeout\` without any deprecation indicator, making them appear as valid current settings. These settings were deprecated in Kibana 8.3.0 when the autocomplete logic was moved from the \`data\` plugin to the \`unified_search\` plugin (now \`kql\`) via [#129977](#129977). The canonical settings since 8.3.0 are \`unifiedSearch.autocomplete.valueSuggestions.terminateAfter\` and \`unifiedSearch.autocomplete.valueSuggestions.timeout\`. The backward-compatible deprecation handler (which remaps the old keys to the new ones with a warning) was accidentally removed in [#246674](#246674) and restored in [#268872](#268872) (backported to v9.4.2 and v9.5.0). During the window between 9.4.0 and 9.4.1, customers using \`data.autocomplete.*\` in \`kibana.yml\` experienced startup failures. All three generations of the settings (\`kibana.*\`, \`data.*\`, \`unifiedSearch.*\`) are explicitly allowlisted in ECH and work for users on ECH deployments. ## Changes - **\`docs/reference/configuration-reference/general-settings.yml\`**: - Marks \`data.autocomplete.valueSuggestions.terminateAfter\` and \`data.autocomplete.valueSuggestions.timeout\` as \`deprecated 8.3\` on stack, with \`deprecation_details\` pointing to the \`unifiedSearch.*\` replacements. - Adds an inline note on both deprecated settings warning that using them in Kibana 9.4.0–9.4.1 causes a startup failure, and advising users to migrate or upgrade. - Adds \`unifiedSearch.autocomplete.valueSuggestions.timeout\` and \`unifiedSearch.autocomplete.valueSuggestions.terminateAfter\` as \`stack: ga 8.3\` entries so the canonical settings are properly documented. ## Resolves Closes elastic/docs-content#6511 --- > **AI-assisted draft** — created with Claude Sonnet 4.6 in Cursor. > Review all generated content for factual accuracy before merging. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
May 22, 2026
…lastic#269868) ## Summary This PR addresses elastic/docs-content#6511. The page [General settings in Kibana](https://www.elastic.co/docs/reference/kibana/configuration-reference/general-settings) lists \`data.autocomplete.valueSuggestions.terminateAfter\` and \`data.autocomplete.valueSuggestions.timeout\` without any deprecation indicator, making them appear as valid current settings. These settings were deprecated in Kibana 8.3.0 when the autocomplete logic was moved from the \`data\` plugin to the \`unified_search\` plugin (now \`kql\`) via [elastic#129977](elastic#129977). The canonical settings since 8.3.0 are \`unifiedSearch.autocomplete.valueSuggestions.terminateAfter\` and \`unifiedSearch.autocomplete.valueSuggestions.timeout\`. The backward-compatible deprecation handler (which remaps the old keys to the new ones with a warning) was accidentally removed in [elastic#246674](elastic#246674) and restored in [elastic#268872](elastic#268872) (backported to v9.4.2 and v9.5.0). During the window between 9.4.0 and 9.4.1, customers using \`data.autocomplete.*\` in \`kibana.yml\` experienced startup failures. All three generations of the settings (\`kibana.*\`, \`data.*\`, \`unifiedSearch.*\`) are explicitly allowlisted in ECH and work for users on ECH deployments. ## Changes - **\`docs/reference/configuration-reference/general-settings.yml\`**: - Marks \`data.autocomplete.valueSuggestions.terminateAfter\` and \`data.autocomplete.valueSuggestions.timeout\` as \`deprecated 8.3\` on stack, with \`deprecation_details\` pointing to the \`unifiedSearch.*\` replacements. - Adds an inline note on both deprecated settings warning that using them in Kibana 9.4.0–9.4.1 causes a startup failure, and advising users to migrate or upgrade. - Adds \`unifiedSearch.autocomplete.valueSuggestions.timeout\` and \`unifiedSearch.autocomplete.valueSuggestions.terminateAfter\` as \`stack: ga 8.3\` entries so the canonical settings are properly documented. ## Resolves Closes elastic/docs-content#6511 --- > **AI-assisted draft** — created with Claude Sonnet 4.6 in Cursor. > Review all generated content for factual accuracy before merging. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It looks like this conversation had a misunderstanding: it focused on the
unifiedSearch->kqlchange, but it forgot the pre-existing rename fromdata.autocompletetounifiedSearch.autocomplete.We've seen some customers hitting this old path, so this PR brings it back.