Management: Index Pattern directory rename / correction#26858
Merged
mattkime merged 4 commits intoelastic:masterfrom Dec 13, 2018
Merged
Management: Index Pattern directory rename / correction#26858mattkime merged 4 commits intoelastic:masterfrom
mattkime merged 4 commits intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
jen-huang
approved these changes
Dec 12, 2018
Contributor
jen-huang
left a comment
jen-huang
left a comment
There was a problem hiding this comment.
LGTM! Smoke tested locally.
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Dec 13, 2018
* correct directory name * fix scss reference
mattkime
added
v7.0.0
v6.7.0
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pretty much one
git mvcommand - Index Pattern code should be in a dir namedindex_patternsinstead ofindices