[9.4] [One Workflow] Use EUI primary tint for word occurrence highlight in YAML editor (#267667)#268532
Merged
Merged
Conversation
…YAML editor (elastic#267667) Before <img width="370" height="235" alt="image" src="https://github.com/user-attachments/assets/98e6bc67-e6ab-40a0-98eb-c012774a26c4" /> After <img width="410" height="264" alt="image" src="https://github.com/user-attachments/assets/639634ef-717f-4b59-bc69-5e03c416cfea" /> ## Summary Replaces the default gray Monaco word-occurrence highlight (visible in the workflows YAML editor when the cursor sits on a token like `name` or `type`) with `euiTheme.colors.backgroundLightPrimary`, so the highlight matches the EUI primary accents already used elsewhere in the editor (selection, hover) instead of reading as a generic gray box. The override is scoped via `[data-test-subj='workflowYamlEditor']` so it only affects the workflows YAML editor — no impact on other Monaco editors in Kibana. ### Before / After - **Before:** Monaco's default neutral gray `wordHighlightText` background. - **After:** EUI `backgroundLightPrimary`, visually consistent with the rest of the editor's primary-tinted highlights. ## Test plan - [ ] Open a workflow in the workflows YAML editor. - [ ] Place the cursor on a YAML key (e.g. `name`, `type`) — all matching occurrences should be highlighted in soft EUI primary blue, not gray. - [ ] Verify the change does NOT bleed into other Monaco-based editors in Kibana (Console, Lens formula bar, etc.). - [ ] Verify in both light and dark EUI themes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> (cherry picked from commit 090eedf)
botelastic
Bot
added
the
Team:One Workflow
4 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @r4zr32d3k1l |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation