Skip to content

[Alerting V2] Updates to the WorkflowService#268419

Merged
adcoelho merged 2 commits into
elastic:mainfrom
adcoelho:alerting-v2-workflow-service-updates
May 8, 2026
Merged

[Alerting V2] Updates to the WorkflowService#268419
adcoelho merged 2 commits into
elastic:mainfrom
adcoelho:alerting-v2-workflow-service-updates

Conversation

@adcoelho
Copy link
Copy Markdown
Contributor

@adcoelho adcoelho commented May 8, 2026

Summary

This PR addresses this comment.

  • I think we should separate the setup from the emitting in the service. It is ok to have only functions for setup, as we do with registerSavedObjects and registerFeaturePrivileges.
  • The service should have only the emitEvent: (triggerId: string, payload: Record<string, unknown>) => Promise.
  • The constructor should accept the workflow client already instantiated with @Inject as we do with the ES and SO client in the other services.
  • Put one README in x-pack/platform/plugins/shared/alerting_v2/public/lib/workflow_extensions for public and one in x-pack/platform/plugins/shared/alerting_v2/server/lib/services/workflow_extensions_service/tokens.ts for server. You can update the x-pack/platform/plugins/shared/alerting_v2/README.md with a paragraph that points to the two files and explains why and how they wire together.

@adcoelho adcoelho requested a review from cnasikas May 8, 2026 12:28
@adcoelho adcoelho self-assigned this May 8, 2026
@adcoelho adcoelho requested a review from a team as a code owner May 8, 2026 12:28
@adcoelho adcoelho added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels May 8, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

infra-vault-gh-plugin-prod Bot commented May 8, 2026

Pinging @elastic/response-ops (Team:ResponseOps)

@adcoelho adcoelho enabled auto-merge (squash) May 8, 2026 13:32
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 8, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Scout Lane #19 - serverless-observability_complete / default / local-serverless-observability_complete - Serverless Observability Navigation - Complete tier body - clicking body nav items sets the active link, updates breadcrumbs, and navigates
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - APM integration not installed but setup completed - Admin user
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Collector integration is not installed - collector integration missing
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Collector integration is not installed - Symbolizer integration is not installed
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Observability Landing Page (discover.isEsqlDefault enabled) - redirects to onboarding when no logs data exists
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Profiling is setup and data is loaded - Admin user
  • [job] [logs] Scout Lane #7 - stateful-classic / default / local-stateful-classic - Profiling is setup and data is loaded - Viewer user

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
alertingVTwo 987 986 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alertingVTwo 44.0KB 43.7KB -281.0B

History

cc @adcoelho

@adcoelho adcoelho merged commit 90f2266 into elastic:main May 8, 2026
31 checks passed
js-jankisalvi pushed a commit to js-jankisalvi/kibana that referenced this pull request May 12, 2026
@adcoelho @js-jankisalvi
[Alerting V2] Updates to the WorkflowService (elastic#268419)
768a2d1 
## Summary

[This PR addresses this
comment.](elastic#267924 (comment))

> - I think we should separate the setup from the emitting in the
service. It is ok to have only functions for setup, as we do with
registerSavedObjects and registerFeaturePrivileges.
> - The service should have only the emitEvent: (triggerId: string,
payload: Record<string, unknown>) => Promise<void>.
> - The constructor should accept the workflow client already
instantiated with @Inject as we do with the ES and SO client in the
other services.
> - Put one README in
x-pack/platform/plugins/shared/alerting_v2/public/lib/workflow_extensions
for public and one in
x-pack/platform/plugins/shared/alerting_v2/server/lib/services/workflow_extensions_service/tokens.ts
for server. You can update the
x-pack/platform/plugins/shared/alerting_v2/README.md with a paragraph
that points to the two files and explains why and how they wire
together.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees

@adcoelho adcoelho

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adcoelho @kibanamachine @cnasikas