[Security Solution] fix wrong banner shown in Discover document flyout because of missing services#268249
Merged
Conversation
…t because of missing services
PhilippeOberti
added
release_note:fix
Team:Threat Hunting
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
DennisKo
approved these changes
May 8, 2026
Contributor
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/25583252813 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
PhilippeOberti
added a commit
that referenced
this pull request
May 12, 2026
… flyout because of missing services (#268249) (#268749) # Backport This will backport the following commits from `main` to `9.4`: - [[Security Solution] fix wrong banner shown in Discover document flyout because of missing services (#268249)](#268249) <!--- Backport version: 11.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2026-05-08T22:46:54Z","message":"[Security Solution] fix wrong banner shown in Discover document flyout because of missing services (#268249)\n\n## Summary\n\nThis PR makes a super small couple of changes:\n\n#### Fix wrong banner message\n\nMove the `RemoteDocumentCallout` inside the `flyoutProviders` to ensure\nthat the `services` are setup correctly. There was an inconsistency when\nopening the flyout in Discover (which was showing `This attack\noriginates from a linked project. Some features may not be available.`)\nand opening the same flyout in a Dashboard where Discover is embedded\n(which was showing `This attack originates from a remote cluster. Some\nfeatures may not be available.`).\n\n#### Remove the `metadataCallout`\n\nRemove the `EuiCallOut` for missing metadata when the `services` or\n`store` aren't defined. This is for better consistency with the header\nand footer sections of the flyout, which are currently both returning\n`null`.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"e46572362f52cd7769e787eeafce1e2b3abc06e9","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting","backport:version","v9.5.0","v9.4.1"],"title":"[Security Solution] fix wrong banner shown in Discover document flyout because of missing services","number":268249,"url":"https://github.com/elastic/kibana/pull/268249","mergeCommit":{"message":"[Security Solution] fix wrong banner shown in Discover document flyout because of missing services (#268249)\n\n## Summary\n\nThis PR makes a super small couple of changes:\n\n#### Fix wrong banner message\n\nMove the `RemoteDocumentCallout` inside the `flyoutProviders` to ensure\nthat the `services` are setup correctly. There was an inconsistency when\nopening the flyout in Discover (which was showing `This attack\noriginates from a linked project. Some features may not be available.`)\nand opening the same flyout in a Dashboard where Discover is embedded\n(which was showing `This attack originates from a remote cluster. Some\nfeatures may not be available.`).\n\n#### Remove the `metadataCallout`\n\nRemove the `EuiCallOut` for missing metadata when the `services` or\n`store` aren't defined. This is for better consistency with the header\nand footer sections of the flyout, which are currently both returning\n`null`.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"e46572362f52cd7769e787eeafce1e2b3abc06e9"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/268249","number":268249,"mergeCommit":{"message":"[Security Solution] fix wrong banner shown in Discover document flyout because of missing services (#268249)\n\n## Summary\n\nThis PR makes a super small couple of changes:\n\n#### Fix wrong banner message\n\nMove the `RemoteDocumentCallout` inside the `flyoutProviders` to ensure\nthat the `services` are setup correctly. There was an inconsistency when\nopening the flyout in Discover (which was showing `This attack\noriginates from a linked project. Some features may not be available.`)\nand opening the same flyout in a Dashboard where Discover is embedded\n(which was showing `This attack originates from a remote cluster. Some\nfeatures may not be available.`).\n\n#### Remove the `metadataCallout`\n\nRemove the `EuiCallOut` for missing metadata when the `services` or\n`store` aren't defined. This is for better consistency with the header\nand footer sections of the flyout, which are currently both returning\n`null`.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"e46572362f52cd7769e787eeafce1e2b3abc06e9"}},{"branch":"9.4","label":"v9.4.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
removed
the
backport missing
clintandrewhall
pushed a commit
that referenced
this pull request
May 12, 2026
…t because of missing services (#268249) ## Summary This PR makes a super small couple of changes: #### Fix wrong banner message Move the `RemoteDocumentCallout` inside the `flyoutProviders` to ensure that the `services` are setup correctly. There was an inconsistency when opening the flyout in Discover (which was showing `This attack originates from a linked project. Some features may not be available.`) and opening the same flyout in a Dashboard where Discover is embedded (which was showing `This attack originates from a remote cluster. Some features may not be available.`). #### Remove the `metadataCallout` Remove the `EuiCallOut` for missing metadata when the `services` or `store` aren't defined. This is for better consistency with the header and footer sections of the flyout, which are currently both returning `null`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a super small couple of changes:
Fix wrong banner message
Move the
RemoteDocumentCalloutinside theflyoutProvidersto ensure that theservicesare setup correctly. There was an inconsistency when opening the flyout in Discover (which was showingThis attack originates from a linked project. Some features may not be available.) and opening the same flyout in a Dashboard where Discover is embedded (which was showingThis attack originates from a remote cluster. Some features may not be available.).Remove the
metadataCalloutRemove the
EuiCallOutfor missing metadata when theservicesorstorearen't defined. This is for better consistency with the header and footer sections of the flyout, which are currently both returningnull.Checklist
release_note:*label is applied per the guidelinesbackport:*labels.