Skip to content

fix(dashboard): stabilize add panel flyout group order and count assertions #268197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gsoldevila wants to merge 1 commit into from
Closed

fix(dashboard): stabilize add panel flyout group order and count assertions #268197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions .../plugins/shared/dashboard/test/scout/ui/parallel_tests/dashboard_add_panel_flyout.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,24 @@ import { expect } from '@kbn/scout/ui';
import { DASHBOARD_DEFAULT_INDEX_TITLE, DASHBOARD_SAVED_SEARCH_ARCHIVE } from '../constants';

const getExpected = (config: ScoutTestConfig) => {
if (config.projectType === 'es' || config.projectType === 'security') {
if (config.projectType === 'es') {
// In ES serverless, xpack.ml.ad.enabled is false, so the 3 Anomaly Detection
// actions (swim lane, anomaly charts, single metric viewer) fail isCompatible
// and are excluded from the flyout.
return {
groups: [
'visualizationsGroup',
'controlsGroup',
'annotation-and-navigationGroup',
'mlGroup',
'logs-aiopsGroup',
'legacyGroup',
],
count: 17,
};
}

if (config.projectType === 'security') {
return {
groups: [
'visualizationsGroup',
Expand Down Expand Up @@ -47,8 +64,7 @@ const getExpected = (config: ScoutTestConfig) => {
* This test exists to ensures additions to menu
* notify our team and can be reviewed by design.
*/
// Failing: See https://github.com/elastic/kibana/issues/268101
spaceTest.describe.skip(
spaceTest.describe(
'Dashboard add panel flyout',
{
tag: [
Expand Down Expand Up @@ -88,7 +104,9 @@ spaceTest.describe.skip(

await spaceTest.step('verify panel groups', async () => {
const groups = await pageObjects.dashboard.getAddPanelFlyoutGroups();
expect(groups).toStrictEqual(expectedGroups);
// Sort before comparing: some groups share the same sort order value and their
// relative position is non-deterministic (depends on async action registration order).
expect([...groups].sort()).toStrictEqual([...expectedGroups].sort());
});

await spaceTest.step('verify total panel count', async () => {
Expand Down
Loading