Merged
Conversation
second merge
Contributor
💚 Build Succeeded |
maryia-lapata
suggested changes
Dec 10, 2018
Nox911
force-pushed
the
feature/translate-url
branch
from
5401c1d to
040ee65
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
maryia-lapata
approved these changes
Dec 11, 2018
Contributor
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
LGTM, I checked with pseudo locale, it works as expected
cjcenizal
suggested changes
Dec 11, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Looks great! Thanks for doing this. I had one small request.
Contributor
💚 Build Succeeded |
cjcenizal
approved these changes
Dec 12, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing this.
Contributor
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Dec 13, 2018
* Translate url * Fix issues * Fix issues
Nox911
pushed a commit
that referenced
this pull request
Dec 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate src/ui/public/url