[Data grid][Scout] Use data view mode by AlexGPlay · Pull Request #267978 · elastic/kibana

AlexGPlay · 2026-05-06T13:55:33Z

Summary

Closes #266912
Closes #266907
Closes #266909
Closes #266910
Closes #266904
Closes #266906
Closes #266911
Closes #266908
Closes #266905
Closes #266903

The latest failures for all the core scout suite in discover points out to discover loading in ESQL mode, to mitigate this a new method has been added to transition to classic view if needed and is now run in the before each.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

kibanamachine · 2026-05-06T15:38:37Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#12136

[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts (--arch stateful --domain classic): 30/30 tests passed.
[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain search): 30/30 tests passed.
[❌] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain observability_complete): 29/30 tests passed.
[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain security_complete): 30/30 tests passed.

see run history

AlexGPlay · 2026-05-07T06:28:22Z

FYI: The flaky test runner passed, the one that didn't was because a docker pull failed, not a real test issue

infra-vault-gh-plugin-prod · 2026-05-07T06:35:04Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta · 2026-05-07T08:03:07Z

    }
  }

+  getCurrentTab() {


Can we introduce another class for unifiedTabs helpers so other teams can also use it for other Kibana pages? The equivalent in functional tests is src/platform/test/functional/page_objects/unified_tabs.ts.

i've simplified this for now, just using local storage to set the query mode - i can create a follow up pr with a unified tabs page object if that sounds good

jughosta · 2026-05-07T10:03:10Z

    // Privileged user is needed to save the search used by the embeddable test.
    await browserAuth.loginAsPrivilegedUser();
+    await pageObjects.discover.setQueryMode('classic');
    await pageObjects.discover.goto();


We could also make it as a parameter for goto. Example:

await pageObjects.discover.goto('classic');

Just an idea.

kibanamachine · 2026-05-07T11:19:49Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#12153

[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts (--arch stateful --domain classic): 30/30 tests passed.
[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain search): 30/30 tests passed.
[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain observability_complete): 30/30 tests passed.
[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts (--arch serverless --domain security_complete): 30/30 tests passed.

see run history

dmlemeshko

lgtm

kibanamachine · 2026-05-08T11:07:16Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: c621b66

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #26 / alerting api integration security and spaces enabled - Group 13 Alerts update space_1_all_alerts_none_actions at space1 should handle updates for a long running alert type without failing the underlying tasks due to invalidated ApiKey
[job] [logs] Scout Lane #39 - serverless-observability_complete / default / local-serverless-observability_complete - Serverless Observability Navigation - Complete tier body - clicking body nav items sets the active link, updates breadcrumbs, and navigates

Metrics [docs]

✅ unchanged

History

💚 Build #439261 succeeded 984af62
💛 Build #438859 was flaky dba1c4c

cc @AlexGPlay

kibanamachine · 2026-05-08T11:13:45Z

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/25552472309

kibanamachine · 2026-05-08T11:22:31Z

💔 All backports failed

Status	Branch	Result
❌	9.4	Backport failed because of merge conflicts You might need to backport the following PRs to 9.4: - [scout] fix cleanup in SO managerment find test (#268349) - test: stabilize serverless Observability Scout navigation and service map (#268240)

Manual backport

To create the backport manually run:

node scripts/backport --pr 267978

Questions ?

Please refer to the Backport tool documentation

AlexGPlay · 2026-05-08T11:36:12Z

Removed backport - this tests only exist in 9.5 😄

…al helper Replaces the streams-local forceClassicDiscoverMode helper with pageObjects.discover.setQueryMode('classic') from kbn-scout's DiscoverApp, added in elastic#267978. Same outcome, no duplicated DISCOVER_QUERY_MODE_KEY constant, no drift risk if Discover renames the storage key. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

#268518) ## Summary Adds per-test `pageObjects.discover.setQueryMode('classic')` call before navigation. Tests that depend on Discover starting in Data view mode now declare that requirement explicitly. Inspired by #267978 - that PR added the `setQueryMode` primitive to `kbn-scout`'s `DiscoverApp` page object to fix the same root cause in Discover's own Scout suite. This PR adopts the same primitive for the `streams_app` Scout suite. - Three specs (`discover_integration_classic`, `discover_integration_wired`, `esql_source_enrichment`) call `pageObjects.discover.setQueryMode('classic')` from `test.beforeEach`. No production code changes. - Reverts `tests/global.setup.ts` to its pre-#268493 form so the suite no longer pins the flag globally — unblocks future ES|QL-default coverage in the same suite. Fixes #246886 Fixes #265663 ## Background The MKI QA serverless environment turned on `discover.isEsqlDefault`, which makes the observability root profile boot Discover into ES|QL with a default query (added in #257268). The affected tests assumed Data view mode by deployment default and broke once the flag flipped. The workaround (#268493) silenced the streams_app suite; this PR makes the dependency explicit per test instead, using the shared `setQueryMode` helper introduced in #267978. --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

## Summary Closes elastic#266912 Closes elastic#266907 Closes elastic#266909 Closes elastic#266910 Closes elastic#266904 Closes elastic#266906 Closes elastic#266911 Closes elastic#266908 Closes elastic#266905 Closes elastic#266903 The latest failures for all the core scout suite in discover points out to discover loading in ESQL mode, to mitigate this a new method has been added to transition to classic view if needed and is now run in the before each. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.

elastic#268518) ## Summary Adds per-test `pageObjects.discover.setQueryMode('classic')` call before navigation. Tests that depend on Discover starting in Data view mode now declare that requirement explicitly. Inspired by elastic#267978 - that PR added the `setQueryMode` primitive to `kbn-scout`'s `DiscoverApp` page object to fix the same root cause in Discover's own Scout suite. This PR adopts the same primitive for the `streams_app` Scout suite. - Three specs (`discover_integration_classic`, `discover_integration_wired`, `esql_source_enrichment`) call `pageObjects.discover.setQueryMode('classic')` from `test.beforeEach`. No production code changes. - Reverts `tests/global.setup.ts` to its pre-elastic#268493 form so the suite no longer pins the flag globally — unblocks future ES|QL-default coverage in the same suite. Fixes elastic#246886 Fixes elastic#265663 ## Background The MKI QA serverless environment turned on `discover.isEsqlDefault`, which makes the observability root profile boot Discover into ES|QL with a default query (added in elastic#257268). The affected tests assumed Data view mode by deployment default and broke once the flag flipped. The workaround (elastic#268493) silenced the streams_app suite; this PR makes the dependency explicit per test instead, using the shared `setQueryMode` helper introduced in elastic#267978. --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Use data view mode

8598906

AlexGPlay self-assigned this May 6, 2026

Run before each also for doc table spec

dba1c4c

AlexGPlay changed the title ~~Use data view mode~~ [Data grid][Scout] Use data view mode May 7, 2026

AlexGPlay added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:version Backport to applied version labels v9.4.1 v9.5.0 labels May 7, 2026

AlexGPlay marked this pull request as ready for review May 7, 2026 06:35

AlexGPlay requested review from a team as code owners May 7, 2026 06:35

jughosta reviewed May 7, 2026

View reviewed changes

Use local storage to set query mode

984af62

jughosta approved these changes May 7, 2026

View reviewed changes

Merge branch 'main' into 266912-use-data-view-mode

c621b66

dmlemeshko approved these changes May 8, 2026

View reviewed changes

AlexGPlay merged commit e85fcb5 into elastic:main May 8, 2026
31 checks passed

AlexGPlay added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels v9.4.1 labels May 8, 2026

github-actions Bot mentioned this pull request May 8, 2026

Failing test: Discover app - errors - should render invalid scripted field error #268458

Open

rStelmach mentioned this pull request May 11, 2026

[Streams][Scout] Replace isEsqlDefault override with per-test helper #268518

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Data grid][Scout] Use data view mode#267978

[Data grid][Scout] Use data view mode#267978
AlexGPlay merged 4 commits into
elastic:mainfrom
AlexGPlay:266912-use-data-view-mode

AlexGPlay commented May 6, 2026 •

edited by kibanamachine

Loading

Uh oh!

kibanamachine commented May 6, 2026

Uh oh!

AlexGPlay commented May 7, 2026

Uh oh!

infra-vault-gh-plugin-prod Bot commented May 7, 2026

Uh oh!

jughosta May 7, 2026 •

edited

Loading

Uh oh!

AlexGPlay May 7, 2026

Uh oh!

jughosta May 7, 2026

Uh oh!

kibanamachine commented May 7, 2026

Uh oh!

dmlemeshko left a comment

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

AlexGPlay commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

AlexGPlay commented May 6, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

kibanamachine commented May 6, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#12136

Uh oh!

AlexGPlay commented May 7, 2026

Uh oh!

infra-vault-gh-plugin-prod Bot commented May 7, 2026

Uh oh!

jughosta May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlexGPlay May 7, 2026

Choose a reason for hiding this comment

Uh oh!

jughosta May 7, 2026

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented May 7, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#12153

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented May 8, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

History

Uh oh!

Uh oh!

kibanamachine commented May 8, 2026

Uh oh!

kibanamachine commented May 8, 2026

💔 All backports failed

Manual backport

Questions ?

Uh oh!

AlexGPlay commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AlexGPlay commented May 6, 2026 •

edited by kibanamachine

Loading

jughosta May 7, 2026 •

edited

Loading