[9.4] Fix data grid full screen stacking (#267339)#267975
Merged
Merged
Conversation
## Summary
When entering full-screen mode on the entities table and opening the
Agent Builder chat, the chant sidebar and its resize handle were hidden
behind the DataGrid overlay but still account for when positioning the
flyout
- `use_full_screen_watcher.ts` + `layout_sidebar.tsx`: introduced a
`data-kbn-preserve-zindex` attribute to exclude elements from the
full-screen z-index reset. This is added to the Chrome sidebar to
preserve its stacking context
- `grid_global_app_style.tsx`: added a constrain to the grid's right
edge (_var(--kbn-layout--sidebar-width)_), so the full-screen DataGrid
no longer covers the sidebar column when the Agent Builder chat is open
## How to test
1. Start Elasticsearch locally
2. Start Kibana locally
<details>
<summary>feature flags used</summary>
uiSettings:
overrides:
agentBuilder:experimentalFeatures: true
securitySolution:entityStoreEnableV2: true
xpack.securitySolution.enableExperimental:
- entityAnalyticsEntityStoreV2
- entityAnalyticsNewHomePageEnabled
</details>
3. Add at least one entity to test
<details>
<summary>Kibana Dev Tools</summary>
POST .entities.v2.latest.security_default-00001/_doc
{
"@timestamp": "2026-05-01T12:00:00.000Z",
"user": { "name": "test.user" },
"entity": {
"name": "test.user",
"type": "Identity",
"id": "user:test.user",
"EngineMetadata": { "Type": "user", "UntypedId": "test.user" }
}
}
</details>
4. Navigate to Security → Entity Analytics
5. Scroll to the entities table and click the full-screen icon
6. Click any entity row to open the entity flyout
7. Click _Add to chat_: click on expand details -> risk contribution to
see the button
8. Confirm that the Agent Builder sidebar is visible and the resize
handle on the sidebar's left edge is visible and draggable
### Before
<img width="1917" height="842" alt="Screenshot 2026-05-01 at 5 08 58 PM"
src="https://github.com/user-attachments/assets/1deaa2f3-b753-4092-9fc9-ade31879f3f3"
/>
### After
https://github.com/user-attachments/assets/829a60fc-80cc-4318-98a8-a69a65a4f89e
(cherry picked from commit 083666e)
Contributor
Author
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
cc @tcalopes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation