Skip to content

[9.4] Fix data grid full screen stacking (#267339)#267975

Merged
kibanamachine merged 1 commit into
elastic:9.4from
kibanamachine:backport/9.4/pr-267339
May 6, 2026
Merged

[9.4] Fix data grid full screen stacking (#267339)#267975
kibanamachine merged 1 commit into
elastic:9.4from
kibanamachine:backport/9.4/pr-267339

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 9.4:

Questions ?

Please refer to the Backport tool documentation

## Summary
When entering full-screen mode on the entities table and opening the
Agent Builder chat, the chant sidebar and its resize handle were hidden
behind the DataGrid overlay but still account for when positioning the
flyout

- `use_full_screen_watcher.ts` + `layout_sidebar.tsx`: introduced a
`data-kbn-preserve-zindex` attribute to exclude elements from the
full-screen z-index reset. This is added to the Chrome sidebar to
preserve its stacking context
- `grid_global_app_style.tsx`: added a constrain to the grid's right
edge (_var(--kbn-layout--sidebar-width)_), so the full-screen DataGrid
no longer covers the sidebar column when the Agent Builder chat is open

## How to test

1. Start Elasticsearch locally
2. Start Kibana locally
      <details>
        <summary>feature flags used</summary>

        uiSettings:
          overrides:
            agentBuilder:experimentalFeatures: true
            securitySolution:entityStoreEnableV2: true

        xpack.securitySolution.enableExperimental:
          - entityAnalyticsEntityStoreV2
          - entityAnalyticsNewHomePageEnabled
      </details>
3. Add at least one entity to test
    <details>
          <summary>Kibana Dev Tools</summary>

          POST .entities.v2.latest.security_default-00001/_doc
          {
            "@timestamp": "2026-05-01T12:00:00.000Z",
            "user": { "name": "test.user" },
            "entity": {
              "name": "test.user",
              "type": "Identity",
              "id": "user:test.user",
"EngineMetadata": { "Type": "user", "UntypedId": "test.user" }
            }
          }
      </details>
4. Navigate to Security → Entity Analytics
5. Scroll to the entities table and click the full-screen icon
6. Click any entity row to open the entity flyout
7. Click _Add to chat_: click on expand details -> risk contribution to
see the button
8. Confirm that the Agent Builder sidebar is visible and the resize
handle on the sidebar's left edge is visible and draggable

### Before

<img width="1917" height="842" alt="Screenshot 2026-05-01 at 5 08 58 PM"
src="https://github.com/user-attachments/assets/1deaa2f3-b753-4092-9fc9-ade31879f3f3"
/>

### After

https://github.com/user-attachments/assets/829a60fc-80cc-4318-98a8-a69a65a4f89e
(cherry picked from commit 083666e)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label May 6, 2026
@kibanamachine kibanamachine enabled auto-merge (squash) May 6, 2026 13:31
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alertingVTwo 628.2KB 628.3KB +72.0B
cloudSecurityPosture 613.1KB 613.2KB +72.0B
discover 1.9MB 1.9MB +72.0B
esql 887.1KB 887.2KB +72.0B
esqlDataGrid 153.2KB 153.3KB +72.0B
osquery 1.3MB 1.3MB +72.0B
securitySolution 12.0MB 12.0MB +72.0B
slo 1.1MB 1.1MB +72.0B
total +576.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 522.0KB 522.1KB +76.0B

cc @tcalopes

@kibanamachine kibanamachine merged commit fb3ebbe into elastic:9.4 May 6, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants