Better fix for page preview size issue#26795
Merged
cqliu1 merged 1 commit intoelastic:masterfrom Dec 12, 2018
Merged
Conversation
Contributor
💚 Build Succeeded |
cqliu1
force-pushed
the
fix/page-preview-thumbnails
branch
from
6a544dc to
1f1baf9
Compare
Contributor
💚 Build Succeeded |
Contributor
|
Before:
After:
|
Contributor
|
@cqliu1 make sure you add some version labels to this pr, and backport appropriately. |
cqliu1
added
review
v7.0.0
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas |
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Dec 12, 2018
cqliu1
added a commit
that referenced
this pull request
Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26562.
This applies the global workpad CSS styles closer to the page previews and allows me to remove the additional div in the previous implementation. The additional div appears to be the cause of the original bug.