Skip to content

add missing apm-server response error monitor#26787

Merged
roncohen merged 2 commits intoelastic:6.5from
graphaelli:more-apm-monitoring-6.5
Dec 7, 2018
Merged

add missing apm-server response error monitor#26787
roncohen merged 2 commits intoelastic:6.5from
graphaelli:more-apm-monitoring-6.5

Conversation

@graphaelli
Copy link
Member

@graphaelli graphaelli commented Dec 6, 2018

backports #26570 to 6.5. That is not merged yet because tests can't pass until a new elasticsearch snapshot including elastic/elasticsearch#36178 is available. That build has been failing for a few days for unrelated reasons. Since the elasticsearch backport of that, in elastic/elasticsearch#36273, is already in the latest 6.5 snapshot, this should pass tests.

before/after:
image

for elastic/apm-server#1614

@graphaelli graphaelli added backport This PR is a backport of another PR Team:Monitoring Stack Monitoring team v6.5.3 labels Dec 6, 2018
@graphaelli graphaelli requested a review from pickypg December 6, 2018 22:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-monitoring

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@roncohen roncohen merged commit 57a468f into elastic:6.5 Dec 7, 2018
@roncohen
Copy link
Contributor

roncohen commented Dec 7, 2018

good work! @graphaelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:Monitoring Stack Monitoring team v6.5.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants