Skip to content

[Streams] Fix VoiceOver announcement of "Add attachments" flyout (#224746) #267805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rStelmach merged 5 commits into from
May 6, 2026
Merged

[Streams] Fix VoiceOver announcement of "Add attachments" flyout (#224746) #267805

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bac0255
fix voiceover
rStelmach May 5, 2026
9bf02dd
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine May 5, 2026
42b884f
move the translation up
rStelmach May 6, 2026
45bab34
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine May 6, 2026
f41bed5
Merge branch 'main' into 224746-observabilitystreams-add-a-dashboard-…
rStelmach May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions .../shared/streams_app/public/components/stream_detail_attachments/add_attachment_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
EuiText,
EuiTitle,
useEuiTheme,
useGeneratedHtmlId,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import React, { useMemo, useState } from 'react';
Expand All @@ -35,6 +34,10 @@ import {
} from './attachment_filters';
import { AttachmentsTable } from './attachment_table';

const flyoutTitleLabel = i18n.translate('xpack.streams.addAttachmentFlyout.flyoutHeaderLabel', {
defaultMessage: 'Add attachments',
});

export function AddAttachmentFlyout({
entityId,
onAddAttachments,
Expand Down Expand Up @@ -91,23 +94,15 @@ export function AddAttachmentFlyout({
[streamsRepositoryClient, entityId, filters.debouncedQuery, filters.types, filters.tags]
);

const flyoutTitleId = useGeneratedHtmlId({
prefix: 'addAttachmentFlyoutTitle',
});

const allAttachments = useMemo(() => {
return attachmentSuggestionsFetch.value?.attachments || [];
}, [attachmentSuggestionsFetch.value]);

return (
<EuiFlyout onClose={onClose} aria-labelledby={flyoutTitleId}>
<EuiFlyout onClose={onClose} aria-label={flyoutTitleLabel}>
<EuiFlyoutHeader hasBorder>
<EuiTitle>
<h2 id={flyoutTitleId}>
{i18n.translate('xpack.streams.addAttachmentFlyout.flyoutHeaderLabel', {
defaultMessage: 'Add attachments',
})}
</h2>
<h2>{flyoutTitleLabel}</h2>
</EuiTitle>
</EuiFlyoutHeader>
<EuiFlyoutBody>
Expand Down
Loading