Fix @elastic/eui/tooltip-focusable-anchor lint violations in kbn-developer-toolbar#267696
Merged
alexwizp merged 3 commits intoMay 5, 2026
Merged
Conversation
6 tasks
…loper-toolbar
Add tabIndex={0} to non-focusable elements inside EuiToolTip for accessibility.
Closes #225189
Agent-Logs-Url: https://github.com/elastic/kibana/sessions/d9cb0687-74a6-4a26-a9a8-f2f753781e66
Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix eslint violations for tooltip focusable anchor
Fix May 5, 2026
@elastic/eui/tooltip-focusable-anchor lint violations in kbn-developer-toolbar
alexwizp
added
release_note:skip
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
/ci |
alexwizp
approved these changes
May 5, 2026
kowalczyk-krzysztof
approved these changes
May 5, 2026
Member
kowalczyk-krzysztof
left a comment
kowalczyk-krzysztof
left a comment
There was a problem hiding this comment.
LGTM but those are developer tools, only available when you run Kibana locally. I wonder if there's any point fixing a11y issues for those?
Contributor
|
@kowalczyk-krzysztof we monitor the entire codebase, and our goal is to fix all a11y-related ESLint violations in Kibana. It’s ultimately simpler to bring the code up to a single standard than to maintain a list of exceptions. |
Contributor
|
@elasticmachine run docs-build |
alexwizp
deleted the
copilot/fix-eslint-violations-tooltip-focusable-anchor
branch
Contributor
|
Starting backport for target branches: 9.3, 9.4 https://github.com/elastic/kibana/actions/runs/25375178266 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
2 tasks
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alexwizp
added a commit
that referenced
this pull request
May 5, 2026
…kbn-developer-toolbar (#267696) (#267817) # Backport This will backport the following commits from `main` to `9.4`: - [Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar (#267696)](#267696) <!--- Backport version: 11.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-05-05T12:02:43Z","message":"Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar (#267696)\n\nCloses: https://github.com/elastic/kibana/issues/267695\n\nAdds `tabIndex={0}` to non-focusable `EuiToolTip` anchor elements so\nkeyboard users can trigger tooltips.\n\n- `environment_indicator.tsx` — `EuiBadge` anchor\n- `frame_jank_indicator.tsx` — `div` anchor\n- `memory_usage_indicator.tsx` — two `EuiBadge` anchors\n\n```tsx\n<EuiToolTip content={tooltipContent}>\n <EuiBadge tabIndex={0} ...>...</EuiBadge>\n</EuiToolTip>\n```\n\nCloses #225189\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"8e309b49044e1d6583a8920ea5a984c509a7c638","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","💝community","backport:version","v9.4.0","a11y:agent-pr","v9.5.0","v9.3.5"],"title":"Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar","number":267696,"url":"https://github.com/elastic/kibana/pull/267696","mergeCommit":{"message":"Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar (#267696)\n\nCloses: https://github.com/elastic/kibana/issues/267695\n\nAdds `tabIndex={0}` to non-focusable `EuiToolTip` anchor elements so\nkeyboard users can trigger tooltips.\n\n- `environment_indicator.tsx` — `EuiBadge` anchor\n- `frame_jank_indicator.tsx` — `div` anchor\n- `memory_usage_indicator.tsx` — two `EuiBadge` anchors\n\n```tsx\n<EuiToolTip content={tooltipContent}>\n <EuiBadge tabIndex={0} ...>...</EuiBadge>\n</EuiToolTip>\n```\n\nCloses #225189\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"8e309b49044e1d6583a8920ea5a984c509a7c638"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/267696","number":267696,"mergeCommit":{"message":"Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar (#267696)\n\nCloses: https://github.com/elastic/kibana/issues/267695\n\nAdds `tabIndex={0}` to non-focusable `EuiToolTip` anchor elements so\nkeyboard users can trigger tooltips.\n\n- `environment_indicator.tsx` — `EuiBadge` anchor\n- `frame_jank_indicator.tsx` — `div` anchor\n- `memory_usage_indicator.tsx` — two `EuiBadge` anchors\n\n```tsx\n<EuiToolTip content={tooltipContent}>\n <EuiBadge tabIndex={0} ...>...</EuiBadge>\n</EuiToolTip>\n```\n\nCloses #225189\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"8e309b49044e1d6583a8920ea5a984c509a7c638"}},{"branch":"9.3","label":"v9.3.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
May 5, 2026
…kbn-developer-toolbar (#267696) (#267818) # Backport This will backport the following commits from `main` to `9.3`: - [Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar (#267696)](#267696) <!--- Backport version: 11.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-05-05T12:02:43Z","message":"Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar (#267696)\n\nCloses: https://github.com/elastic/kibana/issues/267695\n\nAdds `tabIndex={0}` to non-focusable `EuiToolTip` anchor elements so\nkeyboard users can trigger tooltips.\n\n- `environment_indicator.tsx` — `EuiBadge` anchor\n- `frame_jank_indicator.tsx` — `div` anchor\n- `memory_usage_indicator.tsx` — two `EuiBadge` anchors\n\n```tsx\n<EuiToolTip content={tooltipContent}>\n <EuiBadge tabIndex={0} ...>...</EuiBadge>\n</EuiToolTip>\n```\n\nCloses #225189\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"8e309b49044e1d6583a8920ea5a984c509a7c638","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","💝community","backport:version","v9.4.0","a11y:agent-pr","v9.5.0","v9.3.5"],"title":"Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar","number":267696,"url":"https://github.com/elastic/kibana/pull/267696","mergeCommit":{"message":"Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar (#267696)\n\nCloses: https://github.com/elastic/kibana/issues/267695\n\nAdds `tabIndex={0}` to non-focusable `EuiToolTip` anchor elements so\nkeyboard users can trigger tooltips.\n\n- `environment_indicator.tsx` — `EuiBadge` anchor\n- `frame_jank_indicator.tsx` — `div` anchor\n- `memory_usage_indicator.tsx` — two `EuiBadge` anchors\n\n```tsx\n<EuiToolTip content={tooltipContent}>\n <EuiBadge tabIndex={0} ...>...</EuiBadge>\n</EuiToolTip>\n```\n\nCloses #225189\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"8e309b49044e1d6583a8920ea5a984c509a7c638"}},"sourceBranch":"main","suggestedTargetBranches":["9.4","9.3"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/267696","number":267696,"mergeCommit":{"message":"Fix `@elastic/eui/tooltip-focusable-anchor` lint violations in kbn-developer-toolbar (#267696)\n\nCloses: https://github.com/elastic/kibana/issues/267695\n\nAdds `tabIndex={0}` to non-focusable `EuiToolTip` anchor elements so\nkeyboard users can trigger tooltips.\n\n- `environment_indicator.tsx` — `EuiBadge` anchor\n- `frame_jank_indicator.tsx` — `div` anchor\n- `memory_usage_indicator.tsx` — two `EuiBadge` anchors\n\n```tsx\n<EuiToolTip content={tooltipContent}>\n <EuiBadge tabIndex={0} ...>...</EuiBadge>\n</EuiToolTip>\n```\n\nCloses #225189\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"8e309b49044e1d6583a8920ea5a984c509a7c638"}},{"branch":"9.3","label":"v9.3.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #267695
Adds
tabIndex={0}to non-focusableEuiToolTipanchor elements so keyboard users can trigger tooltips.environment_indicator.tsx—EuiBadgeanchorframe_jank_indicator.tsx—divanchormemory_usage_indicator.tsx— twoEuiBadgeanchorsCloses #225189