add skip-so-check label to bypass Saved Objects CI check#267592
Merged
hammad-nasir-elastic merged 4 commits intoMay 6, 2026
Conversation
Provides an escape hatch for unrelated false positives (e.g. Joi version bumps, no-op schema refactors) so that flipping the "Check changes in Saved Objects" step to hard-fail does not block unrelated PRs. Closes elastic/kibana-team#3144 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Pinging @elastic/kibana-core (Team:Core) |
tylersmalley
approved these changes
May 4, 2026
gsoldevila
approved these changes
May 5, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
May 6, 2026
) resolves elastic/kibana-team#3144 ## Summary Adds a `ci:skip-so-check` PR label that, when present, skips the "Check changes in Saved Objects" CI step entirely. This gives contributors an escape hatch for unrelated false positives so that the SO check can be moved toward hard-fail enforcement without holding the whole repo hostage to the next unanticipated edge case. ### Problem - The "Check changes in Saved Objects" step is intended to become a hard-blocking CI check, but historically has produced false positives in cases the rules don't yet model (e.g. `Joi` version bumps that change snapshot hashes without changing semantics, no-op schema refactors). - Today there is no per-PR way to bypass the check when one of these edge cases surfaces; every contributor would have to wait for a Core-side fix. ### Solution - Gate the existing SO-check pipeline step on `!GITHUB_PR_LABELS.includes('ci:skip-so-check')` in `.buildkite/scripts/pipelines/pull_request/pipeline.ts`, following the same pattern as `ci:skip-cypress-osquery` and `agent-builder:skip-smoke-tests`. - When the label is present, the step is simply not emitted into the generated pipeline. - Document the label and its intended use in `packages/kbn-check-saved-objects-cli/README.md` under the existing "How it is used in CI" section. ## How to test 1. Open a PR that touches one of the gating paths (e.g. `packages/kbn-check-saved-objects-cli/current_fields.json`) and confirm the "Check changes in Saved Objects" step appears in Buildkite as today. 2. Add the `ci:skip-so-check` label to the PR, re-run the pipeline build, and confirm the step is no longer emitted. 3. Remove the label and confirm the step reappears on the next pipeline build. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks - Misuse of the label could allow a real, unsafe Saved Object change to merge without validation. Mitigated by the README guidance restricting the label to false positives, and by the fact that the label is opt-in per PR and visible to reviewers. - No risk to existing PRs that do not apply the label — the gating condition is purely additive. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves elastic/kibana-team#3144
Summary
Adds a
ci:skip-so-checkPR label that, when present, skips the "Check changes in Saved Objects" CI step entirely. This gives contributors an escape hatch for unrelated false positives so that the SO check can be moved toward hard-fail enforcement without holding the whole repo hostage to the next unanticipated edge case.Problem
Joiversion bumps that change snapshot hashes without changing semantics, no-op schema refactors).Solution
!GITHUB_PR_LABELS.includes('ci:skip-so-check')in.buildkite/scripts/pipelines/pull_request/pipeline.ts, following the same pattern asci:skip-cypress-osqueryandagent-builder:skip-smoke-tests.packages/kbn-check-saved-objects-cli/README.mdunder the existing "How it is used in CI" section.How to test
packages/kbn-check-saved-objects-cli/current_fields.json) and confirm the "Check changes in Saved Objects" step appears in Buildkite as today.ci:skip-so-checklabel to the PR, re-run the pipeline build, and confirm the step is no longer emitted.Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks