Skip to content

[Workflows] Add editor settings popover to YAML editor#267421

Merged
r4zr32d3k1l merged 3 commits intoelastic:mainfrom
r4zr32d3k1l:feat/workflow-yaml-editor-settings
May 5, 2026
Merged

[Workflows] Add editor settings popover to YAML editor#267421
r4zr32d3k1l merged 3 commits intoelastic:mainfrom
r4zr32d3k1l:feat/workflow-yaml-editor-settings

Conversation

@r4zr32d3k1l
Copy link
Copy Markdown
Contributor

@r4zr32d3k1l r4zr32d3k1l commented May 4, 2026 •
edited by kibanamachine
Loading

Summary

Screen.Recording.2026-04-24.at.20.22.55.mov

Adds an Editor Settings popover icon to the YAML editor bottom bar (to the right of the keyboard shortcuts icon), with two toggles:

  • Show indent guides — vertical grey lines at each indent level (on by default)
  • Show whitespace characters — dots for every space (off by default)

Test plan

  • Open the Workflow YAML editor — verify indent guide lines are visible by default
  • Click the settings icon in the bottom bar — popover opens with two checkboxes
  • Toggle "Show indent guides" off — vertical lines disappear from the editor
  • Toggle "Show whitespace characters" on — dots appear for every space
  • Settings icon and keyboard shortcuts icon coexist correctly in the bottom bar

🤖 Generated with Claude Code

@r4zr32d3k1l @claude
[Workflows] Add editor settings popover to YAML editor bottom bar
7f6a6f0 
Adds a settings icon to the YAML editor bottom bar (alongside the
keyboard shortcuts icon) that opens a popover with two toggles:
- Show indent guides (on by default)
- Show whitespace characters (off by default)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@r4zr32d3k1l r4zr32d3k1l requested a review from a team as a code owner May 4, 2026 09:01
@botelastic botelastic Bot added the Team:One Workflow Team label for One Workflow (Workflow automation) label May 4, 2026
@r4zr32d3k1l r4zr32d3k1l added backport This PR is a backport of another PR backport:version Backport to applied version labels v9.4.0 release_note:skip Skip the PR/issue when compiling release notes and removed backport This PR is a backport of another PR labels May 4, 2026
yngrdyn
yngrdyn reviewed May 4, 2026
View reviewed changes
Comment thread ...ared/workflows_management/public/widgets/workflow_yaml_editor/ui/editor_settings_popover.tsx Outdated

return (
<EuiPopover
css={{ marginLeft: '8px' }}
Copy link
Copy Markdown
Contributor

@yngrdyn yngrdyn May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of direct values, we should be using euiTheme.size values

yngrdyn
yngrdyn reviewed May 4, 2026
View reviewed changes
Comment thread ...ared/workflows_management/public/widgets/workflow_yaml_editor/ui/editor_settings_popover.tsx Outdated
<EuiFlexGroup
direction="column"
gutterSize="s"
css={{ padding: '8px 12px 12px' }}
Copy link
Copy Markdown
Contributor

@yngrdyn yngrdyn May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of direct values, we should be using euiTheme.size values

@r4zr32d3k1l @claude
Use euiTheme.size tokens instead of hardcoded px values
67db843 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yngrdyn
yngrdyn approved these changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@r4zr32d3k1l r4zr32d3k1l enabled auto-merge (squash) May 4, 2026 10:46
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 5, 2026

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
workflowsManagement 1610 1611 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
workflowsManagement 2.3MB 2.3MB +1.9KB

History

@r4zr32d3k1l r4zr32d3k1l merged commit 4935a01 into elastic:main May 5, 2026
24 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 5, 2026

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/25373965517

@kibanamachine kibanamachine mentioned this pull request May 5, 2026
Open
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 5, 2026

💚 All backports created successfully

Status Branch Result
✅ 9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request May 5, 2026
Merged
2 tasks
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 6, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @r4zr32d3k1l

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 7, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @r4zr32d3k1l

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 8, 2026

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @r4zr32d3k1l

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

Assignees

No one assigned

Labels

backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:One Workflow Team label for One Workflow (Workflow automation) v9.4.0 v9.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r4zr32d3k1l @kibanamachine @yngrdyn