Skip to content

[reporting] disable surprisingly failing test#26738

Merged
joelgriffith merged 3 commits intoelastic:masterfrom
spalger:disable-surprisingly-failing-test
Dec 6, 2018
Merged

[reporting] disable surprisingly failing test#26738
joelgriffith merged 3 commits intoelastic:masterfrom
spalger:disable-surprisingly-failing-test

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Dec 5, 2018

These tests started failing on master seemingly out of nowhere, and they're tricky to debug so we are disabling them in master so that @tsullivan has time to debug and fix them.

@spalger spalger added the test label Dec 5, 2018
@spalger spalger requested a review from tsullivan December 5, 2018 23:11
@tylersmalley tylersmalley mentioned this pull request Dec 5, 2018
Merged
@spalger spalger mentioned this pull request Dec 5, 2018
Closed
@joelgriffith joelgriffith self-requested a review December 5, 2018 23:41
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 5, 2018

💔 Build Failed

@tsullivan
Copy link
Member

tsullivan commented Dec 6, 2018

The chromium tests failed because of the reason we're looking into

image

@spalger spalger force-pushed the disable-surprisingly-failing-test branch from b5c25c6 to 586f9e6 Compare December 6, 2018 01:37
@elasticmachine

This comment has been minimized.

Sign in to view
tsullivan
tsullivan approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a lot to turn off. I'm looking into the failures

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 6, 2018

💚 Build Succeeded

@joelgriffith
Copy link
Contributor

joelgriffith commented Dec 6, 2018

I was in the middle of a git bisect workflow. Having pegged 83325bf560 as good. I’m happy to jump back in tomorrow AM since I’m out

@joelgriffith joelgriffith merged commit d3f0db3 into elastic:master Dec 6, 2018
@ryankeairns ryankeairns mentioned this pull request Dec 6, 2018
Merged
@tsullivan
Copy link
Member

tsullivan commented Dec 6, 2018 •
edited
Loading

I'm working on adding more logging on the download route handler, to show the reason why the requested report failed:

? proc [kibana] server log [17:25:12.218] [error][download][reporting] Report jpcvg4q916nha0f068ef44p5 has non-OK status: [500] Reason: [{"message":"Reporting generation failed","reason":"Error: Phantom exited with code: null. Your report may be too large. Try removing some visualizations or increasing the RAM available to Kibana."}]

Still needs investigation

@tsullivan tsullivan mentioned this pull request Dec 7, 2018
Merged
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Dec 12, 2018
@tsullivan
[reporting] disable surprisingly failing test (elastic#26738)
829cd92 
* [reporting] disable surprisingly failing test

* fix expected completion count

* quit chasing, just exclude these configs
@tsullivan tsullivan mentioned this pull request Dec 12, 2018
Merged
tsullivan added a commit that referenced this pull request Dec 13, 2018
@tsullivan
[reporting] disable surprisingly failing test (#26738) (#27068)
18d41b6 
* [reporting] disable surprisingly failing test

* fix expected completion count

* quit chasing, just exclude these configs
@mistic mistic mentioned this pull request Dec 14, 2018
Closed
@spalger spalger deleted the disable-surprisingly-failing-test branch August 18, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsullivan tsullivan tsullivan approved these changes

+1 more reviewer

@joelgriffith joelgriffith joelgriffith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spalger @elasticmachine @tsullivan @joelgriffith