[9.4] [Fleet] Validate SSL certificate paths for whitespace#267275
Open
juliaElastic wants to merge 5 commits intoelastic:9.4from
Open
[9.4] [Fleet] Validate SSL certificate paths for whitespace#267275juliaElastic wants to merge 5 commits intoelastic:9.4from
juliaElastic wants to merge 5 commits intoelastic:9.4from
Conversation
Fixes elastic#265694 TLS certificate fields in Fleet settings forms (Agent binary source, Output, Fleet Server Hosts, Fleet Proxy) accept file paths with spaces without validation. These paths are propagated into the generated agent policy, causing Elastic Agent to fail to resolve the certificate file and become unhealthy. **Shared validator — `common/services/ssl_validators.ts`** - `validateSslCertPath(value)`: rejects whitespace in file paths; exempt when value is PEM content (leading `-----BEGIN`). Works for Linux, Windows (`C:\`, `C:/`), and UNC (`\\server\share`) paths without platform-specific handling. **Client-side adapters — `ssl_form_validators.ts`** - `validateSslPathInput` — adapter for `useInput` (returns `string[] | undefined`) - `validateSslPathsCombo` — adapter for `useComboInput` (returns `Array<{message, index}> | undefined`) **Four form hooks wired** - `use_download_source_flyout_form.tsx` — 3 inputs - `use_output_form.tsx` + `output_form_validators.tsx` — 2 combo inputs + extended existing `validateSSLCertificate`/`validateSSLKey` - `use_fleet_server_host_form.tsx` — 9 inputs across 3 SSL groups (server, ES, agent) - `use_fleet_proxy_form.tsx` — 3 inputs **Four server-side handlers hardened** - `download_source/handler.ts`, `fleet_server_hosts/handler.ts`, `fleet_proxies/handler.ts`, `output/handler.ts` — each gains a `throwIfSslPathInvalid` helper calling the shared common function, returning `400 Bad Request` for invalid paths. 1. Navigate to Fleet → Settings → Agent binary sources → Add / Edit source 2. In the TLS Certificate section, enter a path with spaces (e.g. `/path/to my cert.pem`) in any certificate field 3. Confirm the form shows an error and cannot be saved 4. Confirm a valid path (e.g. `/path/to/cert.pem`) or inline PEM content passes validation 🤖 Generated with [Claude Code](https://claude.com/claude-code) <img width="536" height="829" alt="image" src="https://github.com/user-attachments/assets/5489927a-b71f-4625-9812-15bfea234f06" /> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mason Herron <46727170+Supplementing@users.noreply.github.com>
botelastic
Bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
added
backport
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Needs human review This PR adds input validation that will reject SSL certificate paths containing whitespace across multiple Fleet forms and API endpoints. This is a behavioral change affecting what inputs are accepted, and the author does not own any of the modified files. You can customize Macroscope's approvability policy. Learn more. |
yaml_utils.ts does not exist on the 9.4 branch; remove the two export lines that were incorrectly included during conflict resolution. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
API Contract Breaking Changes — Terraform Provider Impactcc @elastic/fleet The following breaking change(s) affect APIs consumed by the Elastic Terraform Provider.
What to do
See the |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This is a backport of PR #266365 to
9.4.Original PR description
Validates SSL certificate path fields for whitespace characters to prevent
silent failures when saving Fleet settings flyouts.
Conflict resolution
oas_docs/output/kibana.serverless.yamlandkibana.yaml: accepted 9.4 version (generated files)x-pack/platform/plugins/shared/fleet/common/services/index.ts: added only thevalidateSslCertPathexport; excludedyaml_utilsexports that don't exist on 9.4x-pack/platform/plugins/shared/fleet/server/types/models/output.ts: took incomingcompression_levelschema fix (schema.maybe(schema.oneOf([...])))