Skip to content

[Fleet] Fix root level variable replacement yaml migration#266774

Merged
nchaulet merged 2 commits intomainfrom
fix-root-level-variable-replacemen-js-yaml
May 1, 2026
Merged

[Fleet] Fix root level variable replacement yaml migration#266774
nchaulet merged 2 commits intomainfrom
fix-root-level-variable-replacemen-js-yaml

Conversation

@nchaulet
Copy link
Copy Markdown
Member

Summary

Migrating to yaml from js-yaml in #252345 break some agent template features, notably replacing a root yaml variable with quote inside, that PR aim to fix it

Resolve elastic/integrations#18739

Test

I added unit test to cover that change

You can manually try to create a syslog_router package policy and verify it's working as expected

@nchaulet nchaulet self-assigned this Apr 30, 2026
@nchaulet nchaulet requested a review from a team as a code owner April 30, 2026 19:03
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 30, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the backport:skip This PR does not require backporting label Apr 30, 2026
@nchaulet
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 30, 2026

Approvability

Verdict: Needs human review

This PR changes the order of YAML processing operations and modifies stringify behavior in Fleet's template compilation. The changed files are owned by @elastic/fleet, and designated code owners should review changes to their YAML processing logic.

You can customize Macroscope's approvability policy. Learn more.

Copy link
Copy Markdown
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

cc @nchaulet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Stack 9.5.0-SNAPSHOT] [syslog_router] Failing test daily: system test: udp in syslog_router.log

4 participants