[Fleet] Fix root level variable replacement yaml migration#266774
Merged
[Fleet] Fix root level variable replacement yaml migration#266774
Conversation
|
Pinging @elastic/fleet (Team:Fleet) |
Member
Author
|
@elasticmachine merge upstream |
Contributor
ApprovabilityVerdict: Needs human review This PR changes the order of YAML processing operations and modifies stringify behavior in Fleet's template compilation. The changed files are owned by @elastic/fleet, and designated code owners should review changes to their YAML processing logic. You can customize Macroscope's approvability policy. Learn more. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
cc @nchaulet |
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrating to yaml from js-yaml in #252345 break some agent template features, notably replacing a root yaml variable with quote inside, that PR aim to fix it
Resolve elastic/integrations#18739
Test
I added unit test to cover that change
You can manually try to create a
syslog_routerpackage policy and verify it's working as expected