[9.4] [Discover] Reset layout on profile change (#265174)#266238
Merged
Conversation
## Summary This PR fixes the layout carry-over that happens when Discover switches between profiles. Currently when resolving the metrics profile first and then switching to logs, the collapsed table state from metrics leaks into logs even though logs doesn't define that as a profile default: <img src="https://github.com/user-attachments/assets/80a7280c-f2df-4580-83fe-c9c7fd0d769f" /> Now Discover treats initial profile resolution differently from later profile switches. On profile change, Discover restores saved state for that profile when it exists, otherwise it resets layout state back to the shared local storage values before applying profile defaults. This keeps metrics defaults intact while preventing logs from inheriting the table layout when switching from metrics. The PR also moves layout local storage helpers to `@kbn/discover-utils`, simplifies how panel toggle actions are wired into unified histogram, and adds test coverage for the new layout reset behaviour. ### Testing notes Setup: - Ingest some logs and metrics, e.g. with `node scripts/synthtrace logs_and_metrics.ts`. - Create a new o11y space in Kibana. - Use a clean local storage (e.g. private window). The table should shown in this case (same as before): 1. Start with `FROM logs-*` (by refreshing the page once you run that query) 2. `TS metrics-*` 3. `FROM logs-*` The table should now also be shown in this case (new to this PR): 1. Start with `TS metrics-*` (by refreshing the page once you run that query) 2. `FROM logs-*` Resolves elastic#266092. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 09769b0) # Conflicts: # src/platform/plugins/shared/discover/public/components/panels_toggle/panels_toggle.test.tsx # x-pack/platform/plugins/private/translations/translations/de-DE.json # x-pack/platform/plugins/private/translations/translations/fr-FR.json # x-pack/platform/plugins/private/translations/translations/ja-JP.json # x-pack/platform/plugins/private/translations/translations/zh-CN.json
8 tasks
davismcphee
added
the
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
lukasolson
approved these changes
Apr 29, 2026
Contributor
lukasolson
left a comment
lukasolson
left a comment
There was a problem hiding this comment.
Tested in 9.4 and things work as expected. LGTM!
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
History
cc @davismcphee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation