[Security Solution][OneDiscover] Migrate host flyout to v2#265893
Open
kelvtanv wants to merge 50 commits into
Open
[Security Solution][OneDiscover] Migrate host flyout to v2#265893kelvtanv wants to merge 50 commits into
kelvtanv wants to merge 50 commits into
Conversation
…t-for-host-flyout
…t-for-host-flyout
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Split the unified CspInsights tool (which wrapped InsightsTabCsp with a tab strip) into three standalone tools — MisconfigurationInsights, VulnerabilityInsights, AlertsInsights — each rendering a single table component. openDetailsPanel in main/index.tsx now switches on path.subTab within CSP_INSIGHTS to open the matching tool. Added hideHeaderIcon to MisconfigurationsPreview and VulnerabilitiesPreview (matching AlertsPreview's existing prop) so v2 callers can suppress the chevron icon; EntityInsight threads hideMisconfigurationsHeaderIcon and hideVulnerabilitiesHeaderIcon down to those previews. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds hardcoded fixture rows to MisconfigurationInsights and VulnerabilityInsights tools so the components render visibly without a running Elasticsearch. Also wires mockMisconfigurationFindings / mockVulnerabilitiesFindings flags through the v2 host flyout so the EntityInsight previews show even when no real findings exist. Revert this commit to strip all dev scaffolding before shipping. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ols" This reverts commit 94cf444.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
[Security Solution][One Discover] Migrate host flyout subcomponents
…t-for-host-flyout
…FlyoutContent React.lazy() components render asynchronously inside Suspense boundaries, causing getByTestId to find the loading spinner fallback instead of the mocked component. Switch to findByTestId (which waits for the element) to properly handle the async resolution. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #265873
Includes #265876 , kelvtanv#3
Screen.Recording.2026-05-05.at.3.55.17.PM.mov
TODO as follow ups
Note
Some small bugs and organizational fixes are done in downstream PR (kelvtanv#4, kelvtanv#5)
Testing
Pre-req: have some rules and alerts
yarn start csp --data-sources all --findings-count 50)Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.