Skip to content

[sigevents][ki] Raise feature default ttl#265723

Merged
klacabane merged 3 commits into
elastic:mainfrom
klacabane:bump-features-expiration-default
Apr 27, 2026
Merged

[sigevents][ki] Raise feature default ttl#265723
klacabane merged 3 commits into
elastic:mainfrom
klacabane:bump-features-expiration-default

Conversation

@klacabane
Copy link
Copy Markdown
Contributor

@klacabane klacabane commented Apr 27, 2026

Summary

Raise the default ttl of features from 7 to 30 days. Also remove the 90 days limit.

@klacabane klacabane requested review from a team as code owners April 27, 2026 10:08
@klacabane klacabane added release_note:skip Skip the PR/issue when compiling release notes Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) Team:SigEvents Project team working on Significant Events backport:prev-minor v9.5.0 labels Apr 27, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 27, 2026

Approvability

Verdict: Needs human review

CODEOWNERS file was modified by a non-owner — requires human review

You can customize Macroscope's approvability policy. Learn more.

Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Did a quick manual check and I can set 120 days ...

export const DEFAULT_SIG_EVENTS_TUNING_CONFIG: SigEventsTuningConfig = {
sample_size: 20,
max_iterations: 5,
feature_ttl_days: 7,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add this file to the sig.events team's ownership?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbamparop updated in 027d597

@klacabane klacabane enabled auto-merge (squash) April 27, 2026 11:40
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] affected Scout: [ observability / synthetics ] plugin / local-stateful-classic - FilterMonitors - filters monitors by tags with AND/OR logic

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 2.0MB 2.0MB +86.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
streams 13.7KB 13.7KB +1.0B

History

@klacabane klacabane merged commit 3345a23 into elastic:main Apr 27, 2026
20 checks passed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 29, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 265723 locally
cc: @klacabane

5 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 265723 locally
cc: @klacabane

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 265723 locally
cc: @klacabane

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 265723 locally
cc: @klacabane

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 265723 locally
cc: @klacabane

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 265723 locally
cc: @klacabane

@klacabane klacabane added backport:version Backport to applied version labels v9.4.1 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor labels May 7, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/25486454329

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
9.4 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.4:
- [Inference UI] Add scout tests for feature settings page (#261790)

Manual backport

To create the backport manually run:

node scripts/backport --pr 265723

Questions ?

Please refer to the Backport tool documentation

@klacabane klacabane added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels v9.4.1 labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) release_note:skip Skip the PR/issue when compiling release notes Team:SigEvents Project team working on Significant Events v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants