[Security Solution] Adds Inbox plugin#265634
Conversation
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
…ally, or add an exception to src/dev/yarn_deduplicate/index.ts and then commit the changes and push to your branch
🔍 Preview links for changed docs |
Vale Linting ResultsSummary: 1 warning, 1 suggestion found
|
| File | Line | Rule | Message |
|---|---|---|---|
| docs/extend/plugin-list.md | 169 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
💡 Suggestions (1)
| File | Line | Rule | Message |
|---|---|---|---|
| docs/extend/plugin-list.md | 167 | Elastic.Wordiness | Consider using 'all' instead of 'all of '. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
| "group": "platform", | ||
| "visibility": "shared", |
There was a problem hiding this comment.
Just to make sure I'm following - is the idea that observability or search might also drop items into the inbox later on, which is why we’re going with a platform/shared setup?
There was a problem hiding this comment.
Yup! Treating this as a generic platform capability for now to see how managing workflow approvals and surfacing summaries pans out at large. We can lock this down as a security specific implementation later if that makes more sense. RBAC is only surfaced in Security now fwiw, but this should at least give us the flexibility depending on how things shake out.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
cc @spong |
| actions: z.array(InboxAction), | ||
| total: z.number().int(), |
There was a problem hiding this comment.
Consider a TODO re: paging
| export const PLUGIN_ID = 'inbox' as const; | ||
| export const PLUGIN_NAME = 'Inbox' as const; | ||
| export const APP_PATH = '/app/inbox' as const; |
There was a problem hiding this comment.
Re-export from x-pack/platform/packages/shared/kbn-inbox-common/constants.ts?
andrew-goldstein
left a comment
There was a problem hiding this comment.
Thanks @spong for getting the Inbox party started 🎉
LGTM 🚀
…types (#267326) ### Summary Cleanup pass on `@kbn/evals-common` and the `evals` plugin, mirroring what was done for `@kbn/inbox-common` in #265634. No functional changes for end users, but the OAS docs generated from these routes are now correct, and the in-memory cost of the Zod schemas drops via the upstream lazy-bind optimization. ### Changes - **Switch to canonical `buildRouteValidationWithZod` from `@kbn/zod-helpers/v4`** - Deleted the local copy in `kbn-evals-common/impl/schemas/common.ts` and its re-export from `kbn-evals-common/index.ts`. - Updated all 18 evals route files to import the helper from `@kbn/zod-helpers/v4`. - Pruned `@kbn/zod-helpers` and `@kbn/core` from `kbn-evals-common`'s `moon.yml` / `tsconfig.json`; added `@kbn/zod-helpers` to the `evals` plugin's instead. - The canonical helper attaches `_sourceSchema` to the returned validator (added in #263354), which `kbn-router-to-openapispec` unwraps so route `params` / `query` / `body` actually appear in generated OAS docs. The local copy did not, so any OAS doc generation for these routes was silently dropping schema info. - **Regenerated OAS types** (`yarn openapi:generate` in `kbn-evals-common`) - Picks up the `lazySchema(() => …)` wrappers introduced by #264125 and tuned in #266343 (upstream `colinhacks/zod#5897` lazy-bind memory optimization). 19 `.gen.ts` files updated; pattern matches the prior inbox regen exactly. - **README cleanup** — pointed at the new helper location and dropped the obsolete "after regenerating, you may need to fix unused imports" workaround (no longer needed thanks to the OAS-generator `fix_eslint.ts` fix from #265634, which forces the non-editor branch when invoked from agent/IDE terminals). _PR developed with Cursor + Claude Opus 4.7 Super Duper xHigh Thinking++_
Summary
Introduces the
Inboxplugin/package and surrounding scaffolding. Includes plugin with RBAC, stubbed out API routes, and client hooks, andkbn-inbox-commonpackage for OAS generation and zod schemas. Please seeREADME.mdfor detailed architecture.Disabled by default, enabled via
kibana.dev.yml:Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.PR developed with Cursor + Claude Opus 4.7 Super Duper xHigh Thinking++