[8.19] [HTTP] Safer client calls and new browser buildPath utility#265249
Merged
Conversation
…c#257230) - Create a new best-effort ESLint rule that checks if `http<method>` calls are used dangerously: direct path injection - Adds a new `buildPath` utility that can be used with server-side routes `/api/myapi/{id}` to safely build and encode path parameters (**bonus**: server-side path `const`s can be reused by the client directly, no need to build these separately by hand) - Updates existing usages Will flag usages of `http` like: ```ts core.http.delete(`/api/myapi/${id}`, {...}); ``` With a message to use `buildPath` or `encodeURIComponent` in order to safely encode parameters. Not strictly needed in this PR, this utility allows for using server side paths like `/api/myapi/{id}` in a parameterised fashion like: ```ts import { buildPath } from '@kbn/core-http-browser'; buildPath('/api/dashboard/{id}' /* same as { path: ... } server side */, { id }) // => /api/dashboard/encoded-id ``` Happy to exclude this utility if it simplifies things. (Made with cursor y'all) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> (cherry picked from commit 2d72284)
jloleysens
added
Team:Core
jloleysens
changed the title
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
|
jesuswr
approved these changes
Apr 24, 2026
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #257230 to
8.19.Resolved branch-specific conflicts while keeping the older
8.19dashboard and lens implementations intact.Validation
Could not run
node scripts/check_changes.tsor Jest in the temporary backport repo because dependencies are not bootstrapped there.(Made with cursor y'all)