[Security][Workflows] Register workflow steps synchronously using async loaders by KDKHD · Pull Request #265230 · elastic/kibana

KDKHD · 2026-04-23T09:46:24Z

Summary

Follows up on #264788 (merged by @semd) which added async-loader support to the ServerStepRegistry and PublicStepRegistry.

Previously, registerStepDefinition was called inside a deferred getStartServices().then() callback — meaning registration happened after the setup() lifecycle completed. semd flagged this as problematic in review comments on #259159 (comment 1, comment 2).

This PR applies the fix on the security_solution side: registerStepDefinition is now called synchronously during setup(). Each step is registered with an async loader that checks the feature flag at resolution time and returns undefined to skip registration when the flag is disabled.

Changes on both server and public sides:

registerWorkflowSteps is now a synchronous function accepting CoreSetup instead of CoreStart
Each step is wrapped in an async loader that defers the feature-flag check to resolution time
plugin.ts / plugin.tsx call registerWorkflowSteps directly in setup() (no deferred .then())
New unit tests for both server and public registerWorkflowSteps

Test plan

node scripts/jest x-pack/solutions/security/plugins/security_solution/server/workflows/step_types/register_workflow_steps.test.ts
node scripts/jest x-pack/solutions/security/plugins/security_solution/public/workflows/step_types/register_workflow_steps.test.ts
Confirm no regression in existing workflow step tests

Use the async-loader pattern supported by the workflow extension registry (added in elastic#264788) so that `registerStepDefinition` is called synchronously during `setup()` rather than deferred via `getStartServices().then()`. Each step is now registered with an async loader that checks the feature flag at resolution time and returns `undefined` to skip registration when disabled.

KDKHD · 2026-04-23T09:52:47Z

/ci

… across loaders

KDKHD · 2026-04-23T09:54:52Z

/ci

semd · 2026-04-23T10:55:32Z

-  }
+  workflowsExtensions.registerStepDefinition(async () => {
+    if (!(await isEnabled)) return undefined;
+    return renderAlertNarrativeStepDefinition;


Consider lazy-loading the steps themselves as well. So they do not hit the plugin's main bundle size.

Suggested change

return renderAlertNarrativeStepDefinition;

return import('./render_alert_narrative_step').then((m) => m.renderAlertNarrativeStepDefinition);

semd

LGTM!

…duce main bundle size

KDKHD · 2026-04-23T10:59:42Z

/ci

@semd

…nc loaders (elastic#265230) ## Summary Follows up on elastic#264788 (merged by @semd) which added async-loader support to the `ServerStepRegistry` and `PublicStepRegistry`. Previously, `registerStepDefinition` was called inside a deferred `getStartServices().then()` callback — meaning registration happened *after* the `setup()` lifecycle completed. semd flagged this as problematic in review comments on elastic#259159 ([comment 1](elastic#259159 (comment)), [comment 2](elastic#259159 (comment))). This PR applies the fix on the security_solution side: `registerStepDefinition` is now called **synchronously** during `setup()`. Each step is registered with an async loader that checks the feature flag at resolution time and returns `undefined` to skip registration when the flag is disabled. Changes on both server and public sides: - `registerWorkflowSteps` is now a synchronous function accepting `CoreSetup` instead of `CoreStart` - Each step is wrapped in an async loader that defers the feature-flag check to resolution time - `plugin.ts` / `plugin.tsx` call `registerWorkflowSteps` directly in `setup()` (no deferred `.then()`) - New unit tests for both server and public `registerWorkflowSteps` ## Test plan - [ ] `node scripts/jest x-pack/solutions/security/plugins/security_solution/server/workflows/step_types/register_workflow_steps.test.ts` - [ ] `node scripts/jest x-pack/solutions/security/plugins/security_solution/public/workflows/step_types/register_workflow_steps.test.ts` - [ ] Confirm no regression in existing workflow step tests

@semd

…nc loaders (elastic#265230) ## Summary Follows up on elastic#264788 (merged by @semd) which added async-loader support to the `ServerStepRegistry` and `PublicStepRegistry`. Previously, `registerStepDefinition` was called inside a deferred `getStartServices().then()` callback — meaning registration happened *after* the `setup()` lifecycle completed. semd flagged this as problematic in review comments on elastic#259159 ([comment 1](elastic#259159 (comment)), [comment 2](elastic#259159 (comment))). This PR applies the fix on the security_solution side: `registerStepDefinition` is now called **synchronously** during `setup()`. Each step is registered with an async loader that checks the feature flag at resolution time and returns `undefined` to skip registration when the flag is disabled. Changes on both server and public sides: - `registerWorkflowSteps` is now a synchronous function accepting `CoreSetup` instead of `CoreStart` - Each step is wrapped in an async loader that defers the feature-flag check to resolution time - `plugin.ts` / `plugin.tsx` call `registerWorkflowSteps` directly in `setup()` (no deferred `.then()`) - New unit tests for both server and public `registerWorkflowSteps` ## Test plan - [ ] `node scripts/jest x-pack/solutions/security/plugins/security_solution/server/workflows/step_types/register_workflow_steps.test.ts` - [ ] `node scripts/jest x-pack/solutions/security/plugins/security_solution/public/workflows/step_types/register_workflow_steps.test.ts` - [ ] Confirm no regression in existing workflow step tests

@semd

…nc loaders (elastic#265230) ## Summary Follows up on elastic#264788 (merged by @semd) which added async-loader support to the `ServerStepRegistry` and `PublicStepRegistry`. Previously, `registerStepDefinition` was called inside a deferred `getStartServices().then()` callback — meaning registration happened *after* the `setup()` lifecycle completed. semd flagged this as problematic in review comments on elastic#259159 ([comment 1](elastic#259159 (comment)), [comment 2](elastic#259159 (comment))). This PR applies the fix on the security_solution side: `registerStepDefinition` is now called **synchronously** during `setup()`. Each step is registered with an async loader that checks the feature flag at resolution time and returns `undefined` to skip registration when the flag is disabled. Changes on both server and public sides: - `registerWorkflowSteps` is now a synchronous function accepting `CoreSetup` instead of `CoreStart` - Each step is wrapped in an async loader that defers the feature-flag check to resolution time - `plugin.ts` / `plugin.tsx` call `registerWorkflowSteps` directly in `setup()` (no deferred `.then()`) - New unit tests for both server and public `registerWorkflowSteps` ## Test plan - [ ] `node scripts/jest x-pack/solutions/security/plugins/security_solution/server/workflows/step_types/register_workflow_steps.test.ts` - [ ] `node scripts/jest x-pack/solutions/security/plugins/security_solution/public/workflows/step_types/register_workflow_steps.test.ts` - [ ] Confirm no regression in existing workflow step tests

Memoize feature flag check — call getStartServices once, share result…

f0c5444

… across loaders

KDKHD marked this pull request as ready for review April 23, 2026 09:57

KDKHD requested a review from a team as a code owner April 23, 2026 09:57

KDKHD added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Apr 23, 2026

semd reviewed Apr 23, 2026

View reviewed changes

semd approved these changes Apr 23, 2026

View reviewed changes

[Security][Workflows] Lazy-load step modules via dynamic import to re…

669054a

…duce main bundle size

KDKHD enabled auto-merge (squash) April 23, 2026 11:01

Changes from node scripts/eslint_all_files --no-cache --fix

ab9ba15

KDKHD merged commit b8f2e20 into elastic:main Apr 23, 2026
12 checks passed

kibanamachine added the v9.5.0 label Apr 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security][Workflows] Register workflow steps synchronously using async loaders#265230

[Security][Workflows] Register workflow steps synchronously using async loaders#265230
KDKHD merged 4 commits intoelastic:mainfrom
KDKHD:improvement/async-step-registration

KDKHD commented Apr 23, 2026

Uh oh!

KDKHD commented Apr 23, 2026

Uh oh!

KDKHD commented Apr 23, 2026

Uh oh!

semd Apr 23, 2026

Uh oh!

semd left a comment

Uh oh!

KDKHD commented Apr 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	return renderAlertNarrativeStepDefinition;
	return import('./render_alert_narrative_step').then((m) => m.renderAlertNarrativeStepDefinition);

Conversation

KDKHD commented Apr 23, 2026

Summary

Test plan

Uh oh!

KDKHD commented Apr 23, 2026

Uh oh!

KDKHD commented Apr 23, 2026

Uh oh!

semd Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

semd left a comment

Choose a reason for hiding this comment

Uh oh!

KDKHD commented Apr 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants