[9.4] [Fleet] Integration form layout improvements (#262129)#265061
[9.4] [Fleet] Integration form layout improvements (#262129)#265061Supplementing merged 1 commit intoelastic:9.4from
Conversation
## Summary Closes elastic/ingest-dev#7320 This PR adds support for a new var type called `section_header` which allows the integration developer to add an arbitrary EuiTitle element to the UI to be rendered by Kibana in the integrations manifest. Additionally, to help with unwanted section dividers being rendered, users can now set `show_divider` on a var_group stream to have greater control over the way sections are rendered. This PR determines when to render those dividers based on the passed in flag. Also addresses an issue where when using `var_groups`, the selector item would always be placed first, regardless of the actual order of vars. Items are now rendered in order as declared in the manifest so the user has greater control over how fields are rendered in Kibana. Before (notice the lack of headers, and how everything was below the auth selector): <img width="1234" height="880" alt="image" src="https://github.com/user-attachments/assets/d741c756-9d67-4bb5-8b9d-4a54ede7e611" /> After (using the new settings): <img width="1506" height="822" alt="image" src="https://github.com/user-attachments/assets/d123335f-8205-4417-958c-04fa77b3243c" /> ## Testing instructions To test, either run kibana locally using this PR, or spin up a snapshot and upload this integration: [okta-3.14.2.zip](https://github.com/user-attachments/files/26581089/okta-3.14.2.zip) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit a56530d)
|
Pinging @elastic/fleet (Team:Fleet) |
ApprovabilityVerdict: Would Approve This is a UI-only layout improvement for Fleet integration forms, adding decorative section headers and divider controls. All changes are presentation-layer with no impact on policy data or runtime behavior. The author owns all modified files. Macroscope would have approved this PR. Enable approvability here. |
|
Disregard, this does need backported after all as it contains divider and var groups work. We will also backport the other PR which will just overwrite the sections functionality from this PR |
Pull request was closed
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
|
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation