Skip to content

[ML] Fix missing accessible labels on scatterplot matrix form controls #264962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexwizp merged 10 commits into from
Apr 29, 2026
Merged

[ML] Fix missing accessible labels on scatterplot matrix form controls #264962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
05686c8
Initial plan
Copilot Apr 22, 2026
b7a9de2
fix(ml): add accessible labels to scatterplot matrix switch buttons
Copilot Apr 22, 2026
10ebffc
refactor(ml): remove OptionLabelWithIconTip, use EuiFormRow labelAppe…
Copilot Apr 23, 2026
42d16bb
cleanup
alexwizp Apr 24, 2026
dbaf27b
Merge branch 'main' into copilot/ml-results-explorer-fix-switch-title
alexwizp Apr 24, 2026
f2018e6
cleanup
alexwizp Apr 24, 2026
52d1981
Merge branch 'main' into copilot/ml-results-explorer-fix-switch-title
alexwizp Apr 24, 2026
c168ec4
Merge branch 'main' into copilot/ml-results-explorer-fix-switch-title
alexwizp Apr 27, 2026
d6dd5ab
cleanup
alexwizp Apr 28, 2026
6ec6507
Merge branch 'main' into copilot/ml-results-explorer-fix-switch-title
alexwizp Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions x-pack/platform/plugins/private/translations/translations/de-DE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29299,8 +29299,6 @@
"xpack.ml.splom.randomScoringLabel": "Zufällige Wertung",
"xpack.ml.splom.sampleSizeInfoTooltip": "Anzahl der Dokumente, die in der Streudiagrammmatrix angezeigt werden sollen.",
"xpack.ml.splom.sampleSizeLabel": "Stichprobengröße",
"xpack.ml.splom.toggleOff": "Aus",
"xpack.ml.splom.toggleOn": "An",
"xpack.ml.splomSpec.outlierScoreThresholdName": "Schwellenwert für Ausreißerwert:",
"xpack.ml.stepDefineForm.invalidQuery": "Ungültige Abfrage",
"xpack.ml.stepDefineForm.queryPlaceholderKql": "Suchen Sie z. B. nach {example}",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/platform/plugins/private/translations/translations/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29321,8 +29321,6 @@
"xpack.ml.splom.randomScoringLabel": "Scores aléatoires",
"xpack.ml.splom.sampleSizeInfoTooltip": "Quantité de documents à afficher dans la matrice de nuages de points.",
"xpack.ml.splom.sampleSizeLabel": "Taille de l'échantillon",
"xpack.ml.splom.toggleOff": "Arrêt",
"xpack.ml.splom.toggleOn": "Marche",
"xpack.ml.splomSpec.outlierScoreThresholdName": "Seuil de score d'aberrations :",
"xpack.ml.stepDefineForm.invalidQuery": "Requête non valide",
"xpack.ml.stepDefineForm.queryPlaceholderKql": "Rechercher par ex. {example}",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/platform/plugins/private/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29415,8 +29415,6 @@
"xpack.ml.splom.randomScoringLabel": "ランダムスコアリング",
"xpack.ml.splom.sampleSizeInfoTooltip": "散布図マトリックスに表示するドキュメントの数。",
"xpack.ml.splom.sampleSizeLabel": "サンプルサイズ",
"xpack.ml.splom.toggleOff": "オフ",
"xpack.ml.splom.toggleOn": "オン",
"xpack.ml.splomSpec.outlierScoreThresholdName": "異常スコアしきい値：",
"xpack.ml.stepDefineForm.invalidQuery": "無効なクエリー",
"xpack.ml.stepDefineForm.queryPlaceholderKql": "{example}の検索",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/platform/plugins/private/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29414,8 +29414,6 @@
"xpack.ml.splom.randomScoringLabel": "随机评分",
"xpack.ml.splom.sampleSizeInfoTooltip": "在散点图矩阵中药显示的文档数量。",
"xpack.ml.splom.sampleSizeLabel": "样例大小",
"xpack.ml.splom.toggleOff": "关闭",
"xpack.ml.splom.toggleOn": "开启",
"xpack.ml.splomSpec.outlierScoreThresholdName": "离群值分数阈值：",
"xpack.ml.stepDefineForm.invalidQuery": "无效查询",
"xpack.ml.stepDefineForm.queryPlaceholderKql": "搜索，如 {example}）",
Expand Down
26 changes: 8 additions & 18 deletions ...plugins/shared/ml/public/application/components/scatterplot_matrix/scatterplot_matrix.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,6 @@ const SCATTERPLOT_MATRIX_DEFAULT_FETCH_SIZE = 1000;
const SCATTERPLOT_MATRIX_DEFAULT_FETCH_MIN_SIZE = 1;
const SCATTERPLOT_MATRIX_DEFAULT_FETCH_MAX_SIZE = 10000;

const TOGGLE_ON = i18n.translate('xpack.ml.splom.toggleOn', {
defaultMessage: 'On',
});
const TOGGLE_OFF = i18n.translate('xpack.ml.splom.toggleOff', {
defaultMessage: 'Off',
});

const sampleSizeOptions = [100, 1000, 10000].map((d) => ({ value: d, text: '' + d }));

interface OptionLabelWithIconTipProps {
Expand All @@ -88,16 +81,11 @@ interface OptionLabelWithIconTipProps {
}

const OptionLabelWithIconTip: FC<OptionLabelWithIconTipProps> = ({ label, tooltip }) => (
<>
<span aria-label={label}>
{label}
<EuiIconTip
content={tooltip}
iconProps={{
className: 'eui-alignTop',
}}
size="s"
/>
</>
&nbsp;
<EuiIconTip content={tooltip} size="s" />
</span>
);

function filterChartableItems(items: estypes.SearchHit[], resultsField?: string) {
Expand Down Expand Up @@ -513,7 +501,8 @@ export const ScatterplotMatrix: FC<ScatterplotMatrixProps> = ({
<EuiSwitch
data-test-subj="mlScatterplotMatrixRandomizeQuerySwitch"
name="mlScatterplotMatrixRandomizeQuery"
label={randomizeQuery ? TOGGLE_ON : TOGGLE_OFF}
label=""
showLabel={false}
checked={randomizeQuery}
onChange={randomizeQueryOnChange}
disabled={isLoading}
Expand All @@ -538,7 +527,8 @@ export const ScatterplotMatrix: FC<ScatterplotMatrixProps> = ({
>
<EuiSwitch
name="mlScatterplotMatrixDynamicSize"
label={dynamicSize ? TOGGLE_ON : TOGGLE_OFF}
label=""
showLabel={false}
checked={dynamicSize}
onChange={dynamicSizeOnChange}
disabled={isLoading}
Expand Down
Loading