[UII] Fix floating release badges and whitespace in integration policy editor#264866
Merged
jen-huang merged 8 commits intoelastic:mainfrom Apr 23, 2026
Merged
[UII] Fix floating release badges and whitespace in integration policy editor#264866jen-huang merged 8 commits intoelastic:mainfrom
jen-huang merged 8 commits intoelastic:mainfrom
Conversation
jen-huang
added
release_note:skip
jen-huang
changed the title
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
ApprovabilityVerdict: Needs human review UI-only fix for visual layout issues in Fleet's integration policy editor - adjusts badge positioning and whitespace. All files are owned by the author, changes include comprehensive tests, and no runtime behavior is modified beyond presentation. You can customize Macroscope's approvability policy. Learn more. |
nchaulet
approved these changes
Apr 23, 2026
Member
nchaulet
left a comment
nchaulet
left a comment
There was a problem hiding this comment.
tested a few integrations/screen size and seems to work as expected 🚀
Contributor
|
Starting backport for target branches: 9.4 https://github.com/elastic/kibana/actions/runs/24815487639 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
smith
pushed a commit
to smith/kibana
that referenced
this pull request
Apr 23, 2026
…y editor (elastic#264866) ## Summary Resolves elastic#256854 This PR fixes the release badge (`Beta` label) not showing at the input title level for OTel packages (config needed to be expanded in order to see the label). While fixing that, I went down a bit of rabbit hole and found that the release badges and whitespace were just [odd](elastic#256854 (comment)) for input-only packages and single-stream inputs. _(Jen going down a UI rabbit hole? Groundbreaking...)_ I believe this was due to elastic#219287, elastic#254721, and maybe other PRs as part of elastic/ingest-dev#6979. So this PR ended up tweaking conditions for various spacers and flex groups, so that they render (or don't render) correctly. **I recommend reviewing this PR with whitespace turned off.** <img width="794" height="476" alt="image" src="https://github.com/user-attachments/assets/c5253f08-785c-4524-8590-776b0577b110" /> . <img width="800" height="569" alt="image" src="https://github.com/user-attachments/assets/c6cd619f-9179-4a22-89eb-60699b91a293" /> ## Testing Test the policy editor - both in standalone page and in add integration flyout (from agent policy) - with various packages that have GA and non-GA data streams, input-only integrations and regular ones, etc. I tested ones like these: - Azure Event Hub Input - Istio - Nginx OTel - Apache - etc... ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jen-huang
added a commit
that referenced
this pull request
Apr 23, 2026
… policy editor (#264866) (#265394) # Backport This will backport the following commits from `main` to `9.4`: - [[UII] Fix floating release badges and whitespace in integration policy editor (#264866)](#264866) <!--- Backport version: 11.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2026-04-23T03:43:04Z","message":"[UII] Fix floating release badges and whitespace in integration policy editor (#264866)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/256854\n\nThis PR fixes the release badge (`Beta` label) not showing at the input\ntitle level for OTel packages (config needed to be expanded in order to\nsee the label).\n\nWhile fixing that, I went down a bit of rabbit hole and found that the\nrelease badges and whitespace were just\n[odd](https://github.com/elastic/kibana/issues/256854#issuecomment-4284722964)\nfor input-only packages and single-stream inputs. _(Jen going down a UI\nrabbit hole? Groundbreaking...)_ I believe this was due to\nhttps://github.com//pull/219287,\nhttps://github.com//pull/254721, and maybe other PRs as\npart of https://github.com/elastic/ingest-dev/issues/6979.\n\nSo this PR ended up tweaking conditions for various spacers and flex\ngroups, so that they render (or don't render) correctly. **I recommend\nreviewing this PR with whitespace turned off.**\n\n<img width=\"794\" height=\"476\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c5253f08-785c-4524-8590-776b0577b110\"\n/>\n.\n<img width=\"800\" height=\"569\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c6cd619f-9179-4a22-89eb-60699b91a293\"\n/>\n\n## Testing\nTest the policy editor - both in standalone page and in add integration\nflyout (from agent policy) - with various packages that have GA and\nnon-GA data streams, input-only integrations and regular ones, etc. I\ntested ones like these:\n- Azure Event Hub Input\n- Istio\n- Nginx OTel\n- Apache\n- etc...\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"8377aeaf3d7bfef40d814d85efa126b7a5e3cd10","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:version","v9.4.0","v9.5.0"],"title":"[UII] Fix floating release badges and whitespace in integration policy editor","number":264866,"url":"https://github.com/elastic/kibana/pull/264866","mergeCommit":{"message":"[UII] Fix floating release badges and whitespace in integration policy editor (#264866)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/256854\n\nThis PR fixes the release badge (`Beta` label) not showing at the input\ntitle level for OTel packages (config needed to be expanded in order to\nsee the label).\n\nWhile fixing that, I went down a bit of rabbit hole and found that the\nrelease badges and whitespace were just\n[odd](https://github.com/elastic/kibana/issues/256854#issuecomment-4284722964)\nfor input-only packages and single-stream inputs. _(Jen going down a UI\nrabbit hole? Groundbreaking...)_ I believe this was due to\nhttps://github.com//pull/219287,\nhttps://github.com//pull/254721, and maybe other PRs as\npart of https://github.com/elastic/ingest-dev/issues/6979.\n\nSo this PR ended up tweaking conditions for various spacers and flex\ngroups, so that they render (or don't render) correctly. **I recommend\nreviewing this PR with whitespace turned off.**\n\n<img width=\"794\" height=\"476\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c5253f08-785c-4524-8590-776b0577b110\"\n/>\n.\n<img width=\"800\" height=\"569\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c6cd619f-9179-4a22-89eb-60699b91a293\"\n/>\n\n## Testing\nTest the policy editor - both in standalone page and in add integration\nflyout (from agent policy) - with various packages that have GA and\nnon-GA data streams, input-only integrations and regular ones, etc. I\ntested ones like these:\n- Azure Event Hub Input\n- Istio\n- Nginx OTel\n- Apache\n- etc...\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"8377aeaf3d7bfef40d814d85efa126b7a5e3cd10"}},"sourceBranch":"main","suggestedTargetBranches":["9.4"],"targetPullRequestStates":[{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/264866","number":264866,"mergeCommit":{"message":"[UII] Fix floating release badges and whitespace in integration policy editor (#264866)\n\n## Summary\n\nResolves https://github.com/elastic/kibana/issues/256854\n\nThis PR fixes the release badge (`Beta` label) not showing at the input\ntitle level for OTel packages (config needed to be expanded in order to\nsee the label).\n\nWhile fixing that, I went down a bit of rabbit hole and found that the\nrelease badges and whitespace were just\n[odd](https://github.com/elastic/kibana/issues/256854#issuecomment-4284722964)\nfor input-only packages and single-stream inputs. _(Jen going down a UI\nrabbit hole? Groundbreaking...)_ I believe this was due to\nhttps://github.com//pull/219287,\nhttps://github.com//pull/254721, and maybe other PRs as\npart of https://github.com/elastic/ingest-dev/issues/6979.\n\nSo this PR ended up tweaking conditions for various spacers and flex\ngroups, so that they render (or don't render) correctly. **I recommend\nreviewing this PR with whitespace turned off.**\n\n<img width=\"794\" height=\"476\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c5253f08-785c-4524-8590-776b0577b110\"\n/>\n.\n<img width=\"800\" height=\"569\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c6cd619f-9179-4a22-89eb-60699b91a293\"\n/>\n\n## Testing\nTest the policy editor - both in standalone page and in add integration\nflyout (from agent policy) - with various packages that have GA and\nnon-GA data streams, input-only integrations and regular ones, etc. I\ntested ones like these:\n- Azure Event Hub Input\n- Istio\n- Nginx OTel\n- Apache\n- etc...\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.","sha":"8377aeaf3d7bfef40d814d85efa126b7a5e3cd10"}}]}] BACKPORT-->
rbrtj
pushed a commit
to walterra/kibana
that referenced
this pull request
Apr 27, 2026
…y editor (elastic#264866) ## Summary Resolves elastic#256854 This PR fixes the release badge (`Beta` label) not showing at the input title level for OTel packages (config needed to be expanded in order to see the label). While fixing that, I went down a bit of rabbit hole and found that the release badges and whitespace were just [odd](elastic#256854 (comment)) for input-only packages and single-stream inputs. _(Jen going down a UI rabbit hole? Groundbreaking...)_ I believe this was due to elastic#219287, elastic#254721, and maybe other PRs as part of elastic/ingest-dev#6979. So this PR ended up tweaking conditions for various spacers and flex groups, so that they render (or don't render) correctly. **I recommend reviewing this PR with whitespace turned off.** <img width="794" height="476" alt="image" src="https://github.com/user-attachments/assets/c5253f08-785c-4524-8590-776b0577b110" /> . <img width="800" height="569" alt="image" src="https://github.com/user-attachments/assets/c6cd619f-9179-4a22-89eb-60699b91a293" /> ## Testing Test the policy editor - both in standalone page and in add integration flyout (from agent policy) - with various packages that have GA and non-GA data streams, input-only integrations and regular ones, etc. I tested ones like these: - Azure Event Hub Input - Istio - Nginx OTel - Apache - etc... ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Apr 27, 2026
…y editor (elastic#264866) ## Summary Resolves elastic#256854 This PR fixes the release badge (`Beta` label) not showing at the input title level for OTel packages (config needed to be expanded in order to see the label). While fixing that, I went down a bit of rabbit hole and found that the release badges and whitespace were just [odd](elastic#256854 (comment)) for input-only packages and single-stream inputs. _(Jen going down a UI rabbit hole? Groundbreaking...)_ I believe this was due to elastic#219287, elastic#254721, and maybe other PRs as part of elastic/ingest-dev#6979. So this PR ended up tweaking conditions for various spacers and flex groups, so that they render (or don't render) correctly. **I recommend reviewing this PR with whitespace turned off.** <img width="794" height="476" alt="image" src="https://github.com/user-attachments/assets/c5253f08-785c-4524-8590-776b0577b110" /> . <img width="800" height="569" alt="image" src="https://github.com/user-attachments/assets/c6cd619f-9179-4a22-89eb-60699b91a293" /> ## Testing Test the policy editor - both in standalone page and in add integration flyout (from agent policy) - with various packages that have GA and non-GA data streams, input-only integrations and regular ones, etc. I tested ones like these: - Azure Event Hub Input - Istio - Nginx OTel - Apache - etc... ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #256854
This PR fixes the release badge (
Betalabel) not showing at the input title level for OTel packages (config needed to be expanded in order to see the label).While fixing that, I went down a bit of rabbit hole and found that the release badges and whitespace were just odd for input-only packages and single-stream inputs. (Jen going down a UI rabbit hole? Groundbreaking...) I believe this was due to #219287, #254721, and maybe other PRs as part of https://github.com/elastic/ingest-dev/issues/6979.
So this PR ended up tweaking conditions for various spacers and flex groups, so that they render (or don't render) correctly. I recommend reviewing this PR with whitespace turned off.
Testing
Test the policy editor - both in standalone page and in add integration flyout (from agent policy) - with various packages that have GA and non-GA data streams, input-only integrations and regular ones, etc. I tested ones like these:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesbackport:*labels.