[I18n] Update locale data for IntlRelativeFormat and IntlMessageFormat#26468
Merged
LeanidShutau merged 16 commits intoelastic:masterfrom Dec 18, 2018
Merged
Conversation
LeanidShutau
added
Team:Core
Contributor
|
Pinging @elastic/kibana-platform |
Contributor
💔 Build Failed |
Contributor
|
Hmm, is this supposed to include so many fewer locales? |
azasypkin
changed the title
Contributor
No it's just WIP (I just marked it like so), we're discussing right now which locales to include. Here is the list we need to support for not too distant future:
|
…tive-format-locale-data
…tive-format-locale-data
LeanidShutau
changed the title
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
LeanidShutau
force-pushed
the
feature/i18n-relative-format-locale-data
branch
from
8995eca to
b4cf637
Compare
Contributor
💚 Build Succeeded |
maryia-lapata
approved these changes
Dec 7, 2018
Contributor
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
LGTM with two comments.
I've checked locally, it works as excepted.
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
…tive-format-locale-data
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
azasypkin
approved these changes
Dec 12, 2018
Contributor
azasypkin
left a comment
azasypkin
left a comment
There was a problem hiding this comment.
LGTM with one optional suggestion. Also can you please check that FormatRelative works with Phantom reporting as expected (in Chinese for example)?
Contributor
💚 Build Succeeded |
Contributor
Author
|
|
LeanidShutau
added a commit
that referenced
this pull request
Dec 21, 2018
#26468) * [I18n] Update locale data for IntlRelativeFormat and IntlMessageFormat * Update locales * Add default relative formats * Fix en locale formats * Update readme * Make setFormats public * Update snapshots * Resolve comments * Update locales list * Update snapshots * Add locale data for pseudo-locale
LeanidShutau
added a commit
that referenced
this pull request
Dec 21, 2018
#26468) (#27375) * [I18n] Update locale data for IntlRelativeFormat and IntlMessageFormat * Update locales * Add default relative formats * Fix en locale formats * Update readme * Make setFormats public * Update snapshots * Resolve comments * Update locales list * Update snapshots * Add locale data for pseudo-locale
Contributor
Author
|
6.x/6.7: 65a26c8 |
2 tasks
weltenwort
added a commit
that referenced
this pull request
Mar 18, 2019
…ent (#33146) This replaces the custom relative time component in the Logs UI live streaming inline loading indicator with the one from `react-intl`. This was not done at the time of the initial i18n introduction (#25213), because of #26237, which apparently has since been resolved via #26468. Visual changes should be limited to `now` being shown instead of `0s ago`.
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Mar 18, 2019
…ent (elastic#33146) This replaces the custom relative time component in the Logs UI live streaming inline loading indicator with the one from `react-intl`. This was not done at the time of the initial i18n introduction (elastic#25213), because of elastic#26237, which apparently has since been resolved via elastic#26468. Visual changes should be limited to `now` being shown instead of `0s ago`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #26237