back to canvas way of loading plugins#26463
Conversation
💔 Build Failed |
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Tested locally (Chrome OSX), and loading custom plugins is working for me now.
Code LGTM too (other than the leftover console.log statements which need to be removed still), but we should get a sanity check from the Canvas team before merging.
ppisljar
force-pushed
the
canvasPluginLoading
branch
from
20e4a5a to
482c447
Compare
ppisljar
added
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-app |
|
Pinging @elastic/kibana-canvas |
ppisljar
force-pushed
the
canvasPluginLoading
branch
from
482c447 to
484b34a
Compare
💔 Build Failed |
ppisljar
force-pushed
the
canvasPluginLoading
branch
from
484b34a to
3f323d9
Compare
💔 Build Failed |
|
retest |
💔 Build Failed |
ppisljar
force-pushed
the
canvasPluginLoading
branch
from
3f323d9 to
8dbdc5e
Compare
💚 Build Succeeded |
clintandrewhall
left a comment
clintandrewhall
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick work on this.
| method: 'GET', | ||
| path: '/api/canvas/plugins', | ||
| handler: function (request) { | ||
| handler: function (request, h) { |
There was a problem hiding this comment.
Could you make this a fully-stated variable, so it's clear what this is?
There was a problem hiding this comment.
FYI, h is the standard name for the response toolkit in newer versions of Hapi
rashidkpc
left a comment
rashidkpc
left a comment
There was a problem hiding this comment.
This LGTM, plugins seem to load ok and I know a couple other people that have made plugins work off of this.
6 participants
Summary
During moving interpreter to OSS dynamic plugin loading was broken, this tries to fix it, and goes back to the way canvas handled plugin loading before
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[x] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately