[Fleet] Fix agentless integrations incorrect splash screen(s)#264570
Conversation
…so fixed splash screen flashing (now shows loading when !packageInfo
|
Pinging @elastic/fleet (Team:Fleet) |
ApprovabilityVerdict: Needs human review This bug fix changes UI routing logic for agentless integrations. All changed files are owned by @elastic/fleet, not the PR author. Additionally, there's an unresolved review comment questioning whether part of the implementation is necessary, which warrants owner review. You can customize Macroscope's approvability policy. Learn more. |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
|
Also, consider backporting this fix. I think the bug has been around for a while unfortunately :( |
…uting level and never land there with agentless anyway
jen-huang
left a comment
There was a problem hiding this comment.
Much cleaner now! Ty for the changes, LGTM
|
Starting backport for target branches: 9.3, 9.4 https://github.com/elastic/kibana/actions/runs/24794700970 |
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…264570) (#265119) # Backport This will backport the following commits from `main` to `9.4`: - [[Fleet] Fix agentless integrations incorrect splash screen(s) (#264570)](#264570) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Mason Herron","email":"46727170+Supplementing@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-04-22T18:10:39Z","message":"[Fleet] Fix agentless integrations incorrect splash screen(s) (#264570)\n\n## Summary\n\nThis PR is a follow up bug fix to\nhttps://github.com//pull/263552\n\nWe noticed that after hiding the splash screen, users would still be\nredirected to another screen insisting they install elastic agent when\nusing an agentless integration, which wasnt correct. This PR fixes that.\nAdditionally, there was a small 'flash' where when the packageInfo was\nnot yet populated, the original splash screen removed in\nhttps://github.com//pull/263552 would render for a split\nsecond as the default behavior, this PR also fixes that. The fix is a\nrouting check to skip multiPageLayouts for agentless integrations.\n\n\n\n\nhttps://github.com/user-attachments/assets/78e97aa8-494e-444d-bb0b-f3f2c665337e\n\n\n\n## Testing\n\nAdd the following to your kibana.dev.yml file: \n\n```\nxpack.fleet.agentless.customIntegrations.enabled: true\n# Emulate cloud + agentless for local testing\nxpack.cloud.id: '123456789'\nxpack.fleet.agentless.enabled: true\nxpack.fleet.agentless.api.url: 'https://api.agentless.url/api/v1/ess'\nxpack.fleet.agentless.api.tls.certificate: './config/node.crt'\nxpack.fleet.agentless.api.tls.key: './config/node.key'\nxpack.fleet.agentless.api.tls.ca: './config/ca.crt'\n```\n\nThen install this custom integration: \n\n[custom_okta-3.14.2.zip](https://github.com/user-attachments/files/26917447/custom_okta-3.14.2.zip)\n\ncc: @nimarezainia \n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"875255616c6e07edf3b30ea382a82e6680cc0f6f","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:version","v9.3.0","v9.4.0","v9.5.0"],"title":"[Fleet] Fix agentless integrations incorrect splash screen(s)","number":264570,"url":"https://github.com/elastic/kibana/pull/264570","mergeCommit":{"message":"[Fleet] Fix agentless integrations incorrect splash screen(s) (#264570)\n\n## Summary\n\nThis PR is a follow up bug fix to\nhttps://github.com//pull/263552\n\nWe noticed that after hiding the splash screen, users would still be\nredirected to another screen insisting they install elastic agent when\nusing an agentless integration, which wasnt correct. This PR fixes that.\nAdditionally, there was a small 'flash' where when the packageInfo was\nnot yet populated, the original splash screen removed in\nhttps://github.com//pull/263552 would render for a split\nsecond as the default behavior, this PR also fixes that. The fix is a\nrouting check to skip multiPageLayouts for agentless integrations.\n\n\n\n\nhttps://github.com/user-attachments/assets/78e97aa8-494e-444d-bb0b-f3f2c665337e\n\n\n\n## Testing\n\nAdd the following to your kibana.dev.yml file: \n\n```\nxpack.fleet.agentless.customIntegrations.enabled: true\n# Emulate cloud + agentless for local testing\nxpack.cloud.id: '123456789'\nxpack.fleet.agentless.enabled: true\nxpack.fleet.agentless.api.url: 'https://api.agentless.url/api/v1/ess'\nxpack.fleet.agentless.api.tls.certificate: './config/node.crt'\nxpack.fleet.agentless.api.tls.key: './config/node.key'\nxpack.fleet.agentless.api.tls.ca: './config/ca.crt'\n```\n\nThen install this custom integration: \n\n[custom_okta-3.14.2.zip](https://github.com/user-attachments/files/26917447/custom_okta-3.14.2.zip)\n\ncc: @nimarezainia \n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"875255616c6e07edf3b30ea382a82e6680cc0f6f"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.4"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.4","label":"v9.4.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/264570","number":264570,"mergeCommit":{"message":"[Fleet] Fix agentless integrations incorrect splash screen(s) (#264570)\n\n## Summary\n\nThis PR is a follow up bug fix to\nhttps://github.com//pull/263552\n\nWe noticed that after hiding the splash screen, users would still be\nredirected to another screen insisting they install elastic agent when\nusing an agentless integration, which wasnt correct. This PR fixes that.\nAdditionally, there was a small 'flash' where when the packageInfo was\nnot yet populated, the original splash screen removed in\nhttps://github.com//pull/263552 would render for a split\nsecond as the default behavior, this PR also fixes that. The fix is a\nrouting check to skip multiPageLayouts for agentless integrations.\n\n\n\n\nhttps://github.com/user-attachments/assets/78e97aa8-494e-444d-bb0b-f3f2c665337e\n\n\n\n## Testing\n\nAdd the following to your kibana.dev.yml file: \n\n```\nxpack.fleet.agentless.customIntegrations.enabled: true\n# Emulate cloud + agentless for local testing\nxpack.cloud.id: '123456789'\nxpack.fleet.agentless.enabled: true\nxpack.fleet.agentless.api.url: 'https://api.agentless.url/api/v1/ess'\nxpack.fleet.agentless.api.tls.certificate: './config/node.crt'\nxpack.fleet.agentless.api.tls.key: './config/node.key'\nxpack.fleet.agentless.api.tls.ca: './config/ca.crt'\n```\n\nThen install this custom integration: \n\n[custom_okta-3.14.2.zip](https://github.com/user-attachments/files/26917447/custom_okta-3.14.2.zip)\n\ncc: @nimarezainia \n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"875255616c6e07edf3b30ea382a82e6680cc0f6f"}}]}] BACKPORT--> Co-authored-by: Mason Herron <46727170+Supplementing@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…c#264570) ## Summary This PR is a follow up bug fix to elastic#263552 We noticed that after hiding the splash screen, users would still be redirected to another screen insisting they install elastic agent when using an agentless integration, which wasnt correct. This PR fixes that. Additionally, there was a small 'flash' where when the packageInfo was not yet populated, the original splash screen removed in elastic#263552 would render for a split second as the default behavior, this PR also fixes that. The fix is a routing check to skip multiPageLayouts for agentless integrations. https://github.com/user-attachments/assets/78e97aa8-494e-444d-bb0b-f3f2c665337e ## Testing Add the following to your kibana.dev.yml file: ``` xpack.fleet.agentless.customIntegrations.enabled: true # Emulate cloud + agentless for local testing xpack.cloud.id: '123456789' xpack.fleet.agentless.enabled: true xpack.fleet.agentless.api.url: 'https://api.agentless.url/api/v1/ess' xpack.fleet.agentless.api.tls.certificate: './config/node.crt' xpack.fleet.agentless.api.tls.key: './config/node.key' xpack.fleet.agentless.api.tls.ca: './config/ca.crt' ``` Then install this custom integration: [custom_okta-3.14.2.zip](https://github.com/user-attachments/files/26917447/custom_okta-3.14.2.zip) cc: @nimarezainia ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…c#264570) ## Summary This PR is a follow up bug fix to elastic#263552 We noticed that after hiding the splash screen, users would still be redirected to another screen insisting they install elastic agent when using an agentless integration, which wasnt correct. This PR fixes that. Additionally, there was a small 'flash' where when the packageInfo was not yet populated, the original splash screen removed in elastic#263552 would render for a split second as the default behavior, this PR also fixes that. The fix is a routing check to skip multiPageLayouts for agentless integrations. https://github.com/user-attachments/assets/78e97aa8-494e-444d-bb0b-f3f2c665337e ## Testing Add the following to your kibana.dev.yml file: ``` xpack.fleet.agentless.customIntegrations.enabled: true # Emulate cloud + agentless for local testing xpack.cloud.id: '123456789' xpack.fleet.agentless.enabled: true xpack.fleet.agentless.api.url: 'https://api.agentless.url/api/v1/ess' xpack.fleet.agentless.api.tls.certificate: './config/node.crt' xpack.fleet.agentless.api.tls.key: './config/node.key' xpack.fleet.agentless.api.tls.ca: './config/ca.crt' ``` Then install this custom integration: [custom_okta-3.14.2.zip](https://github.com/user-attachments/files/26917447/custom_okta-3.14.2.zip) cc: @nimarezainia ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…c#264570) ## Summary This PR is a follow up bug fix to elastic#263552 We noticed that after hiding the splash screen, users would still be redirected to another screen insisting they install elastic agent when using an agentless integration, which wasnt correct. This PR fixes that. Additionally, there was a small 'flash' where when the packageInfo was not yet populated, the original splash screen removed in elastic#263552 would render for a split second as the default behavior, this PR also fixes that. The fix is a routing check to skip multiPageLayouts for agentless integrations. https://github.com/user-attachments/assets/78e97aa8-494e-444d-bb0b-f3f2c665337e ## Testing Add the following to your kibana.dev.yml file: ``` xpack.fleet.agentless.customIntegrations.enabled: true # Emulate cloud + agentless for local testing xpack.cloud.id: '123456789' xpack.fleet.agentless.enabled: true xpack.fleet.agentless.api.url: 'https://api.agentless.url/api/v1/ess' xpack.fleet.agentless.api.tls.certificate: './config/node.crt' xpack.fleet.agentless.api.tls.key: './config/node.key' xpack.fleet.agentless.api.tls.ca: './config/ca.crt' ``` Then install this custom integration: [custom_okta-3.14.2.zip](https://github.com/user-attachments/files/26917447/custom_okta-3.14.2.zip) cc: @nimarezainia ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
…c#264570) ## Summary This PR is a follow up bug fix to elastic#263552 We noticed that after hiding the splash screen, users would still be redirected to another screen insisting they install elastic agent when using an agentless integration, which wasnt correct. This PR fixes that. Additionally, there was a small 'flash' where when the packageInfo was not yet populated, the original splash screen removed in elastic#263552 would render for a split second as the default behavior, this PR also fixes that. The fix is a routing check to skip multiPageLayouts for agentless integrations. https://github.com/user-attachments/assets/78e97aa8-494e-444d-bb0b-f3f2c665337e ## Testing Add the following to your kibana.dev.yml file: ``` xpack.fleet.agentless.customIntegrations.enabled: true # Emulate cloud + agentless for local testing xpack.cloud.id: '123456789' xpack.fleet.agentless.enabled: true xpack.fleet.agentless.api.url: 'https://api.agentless.url/api/v1/ess' xpack.fleet.agentless.api.tls.certificate: './config/node.crt' xpack.fleet.agentless.api.tls.key: './config/node.key' xpack.fleet.agentless.api.tls.ca: './config/ca.crt' ``` Then install this custom integration: [custom_okta-3.14.2.zip](https://github.com/user-attachments/files/26917447/custom_okta-3.14.2.zip) cc: @nimarezainia ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
This PR is a follow up bug fix to #263552
We noticed that after hiding the splash screen, users would still be redirected to another screen insisting they install elastic agent when using an agentless integration, which wasnt correct. This PR fixes that. Additionally, there was a small 'flash' where when the packageInfo was not yet populated, the original splash screen removed in #263552 would render for a split second as the default behavior, this PR also fixes that. The fix is a routing check to skip multiPageLayouts for agentless integrations.
video1457578972.mp4
Testing
Add the following to your kibana.dev.yml file:
Then install this custom integration:
custom_okta-3.14.2.zip
cc: @nimarezainia
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.