[9.4] [Lens as code] Fix XY line chart breakdown dimension showing default palette instead of elastic_line_optimized (#264147)#264406
Merged
kibanamachine merged 1 commit intoelastic:9.4from Apr 20, 2026
Conversation
…` palette instead of `elastic_line_optimized` (elastic#264147) ## Summary Fix elastic#264123 This PR fixes the wrong color palette shown in the dimension editor of an XY line chart when created from API without explicit `color`: Three code paths hardcoded `'default'` as the palette fallback instead of checking the series type: - **`getLayerPaletteName`** in `color_assignment.ts` —> used for color assignment grouping and the visualization info palette - **`getConfiguration`** in `visualization.tsx` —> the breakdown dimension palette indicator swatches - **`DataDimensionEditor`** in `dimension_editor.tsx` —> the `ColorMappingByTerms` color mapping editor All three now resolve through the existing `getDefaultPalette(seriesType)` helper from `default_palette.ts`, which is the single source of truth already used by the renderer. ## Screenshots after the fix 1. Breakdown color mapping palette <img width="1214" height="734" alt="Screenshot 2026-04-17 at 6 18 57 PM" src="https://github.com/user-attachments/assets/23bee1a3-2899-4bf3-97e4-0049164eea94" /> 2. Color assignment grouping for y-axis dimensions <img width="1287" height="734" alt="Screenshot 2026-04-17 at 6 20 55 PM" src="https://github.com/user-attachments/assets/f8d02807-a9dc-4767-99e9-f2362c8ff0a9" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 0d6acba)
3 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:defaultpalette instead ofelastic_line_optimized(#264147)Questions ?
Please refer to the Backport tool documentation