[9.4] Add tableCaption to EuiBasicTable in insights summary for accessibility (#263424)#264101
Merged
kibanamachine merged 1 commit intoelastic:9.4from Apr 17, 2026
Merged
Conversation
…bility (elastic#263424) Closes: elastic#263423 The `EuiBasicTable` in the significant events insights summary was missing the required `tableCaption` prop, violating `@elastic/eui/require-table-caption`. - Added i18n-translated `tableCaption` to the insights table in `summary.tsx`, following the same pattern as other tables in `sig_events/` ```tsx <EuiBasicTable tableCaption={i18n.translate('xpack.streams.insights.tableCaption', { defaultMessage: 'Significant events insights', })} ... /> ``` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `ci-stats.kibana.dev` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/kbn bootstrap` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node scripts/yarn_install_scripts.js run ldd 0.8.2 nibrowser-gtk/sys/lib/libbrotlidec.so.1.0.7 git e_modules/npm/bin/node-gyp-bin/ldd &elastic#34;@elastic/eui/re/lib/ld-linux.so.2 --global de/node/bin/bash/home/REDACTED/.cache/ms-playwright/webkit-2272/minibrowser-wpe/sys/lib/libbrotlicommon.so.1 /lib/ld-linux.so.2 b/li��` (dns block) > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node node scripts/eslint x-pack/platform/plugins/shared/streams_app/public/components/sig_events/significant_events_discovery/components/insights/summary.tsx 53 -j ACCEPT _discovery/components/insights/summary.tsx v22.22.0/bin/node_modules/npm/bin/node-gyp-bin/ldd unset --global tnet/tools/bash ldd s/li�� i] !~ /^[0-9]&elastic#43;$/) { exit(0); } user.email git /lib/node_modules/npm/bin/node-gyp-bin/ldd get --local /usr/local/bin/g-t $0; sep=RS }` (dns block) > - `clients3.google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack /lib/ld-linux.so.2 0.8.2` (dns block) > - `detectportal.firefox.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack /lib/ld-linux.so.2 0.8.2` (dns block) > - `google.com` > - Triggering command: `/home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon /home/REDACTED/work/kibana/kibana/node_modules/@moonrepo/core-linux-x64-gnu/moon run :build-webpack /lib/ld-linux.so.2 0.8.2` (dns block) > - `googlechromelabs.github.io` > - Triggering command: `/home/REDACTED/.nvm/versions/node/v22.22.0/bin/node /home/REDACTED/.nvm/versions/node/v22.22.0/bin/node install.js t ldd b/li��` (dns block) > - `iojs.org` > - Triggering command: `/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/elastic/kibana/settings/copilot/coding_agent) (admins only) > > </details> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexwizp <20072247+alexwizp@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> (cherry picked from commit bd59f0e)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:tableCaptiontoEuiBasicTablein insights summary for accessibility (#263424)Questions ?
Please refer to the Backport tool documentation