[skip mki] create_steps.spec.ts#263984
Merged
dmlemeshko merged 1 commit intoelastic:mainfrom Apr 17, 2026
Merged
Conversation
dmlemeshko
added
release_note:skip
Contributor
Catch flakiness early (recommended)Recommended before merge: run the flaky test runner against this PR to catch flakiness early. Trigger a run with the Flaky Test Runner UI or post this comment on the PR: This check is experimental. Share your feedback in the #appex-qa channel. Posted via Macroscope — Flaky Test Runner nudge |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
|
flash1293
approved these changes
Apr 17, 2026
rStelmach
added a commit
that referenced
this pull request
Apr 21, 2026
closes: #258589 ## Summary Re-enables the Streams UI test `should not show Technical Preview badge when AI suggestions are unavailable` on serverless observability (MKI). The test was skipped in #263984 while it was failing deterministically on the MKI. The underlying bug was fixed by #263843 after this test was skipped ## Root cause **Root cause of the original failure (fixed):** Before #263843, `useLoadConnectors` in `@kbn/inference-connectors` had a client-side fallback that called `fetchConnectorById` against `GET /internal/inference/connectors/{id}` whenever `soEntryFound === false` and `defaultConnectorId` was truthy. The test's `page.route` mock only covered `**/internal/search_inference_endpoints/connectors*`, so the fallback slipped past the mock and returned the project's EIS connector. The Technical Preview badge (and the "Elastic Managed LLM is the new default" callout) then rendered, and the assertion failed. This was MKI-only because the fallback is gated on `defaultConnectorId` being truthy, which requires the `GEN_AI_SETTINGS_DEFAULT_AI_CONNECTOR` uiSetting to be configured. Serverless observability CI projects preconfigure that setting to an EIS inference endpoint; local stateful / ECH environments do not, so the fallback short-circuited there. **How #263843 fixed it:** Removed the client-side fallback entirely. Default-connector merging now happens server-side in `mergeConnectors` (`x-pack/platform/plugins/shared/search_inference_endpoints/server/lib/merge_connectors.ts`). After the fix, `useLoadConnectors` makes exactly one HTTP call to the endpoint the test already mocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skipping test for MKI runs due to regular failures
See #258589